Automatically de-duplicate rules when loading rules - #571
Merged
Conversation
- also code refinement Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
============================================
+ Coverage 39.09% 40.51% +1.41%
- Complexity 1196 1314 +118
============================================
Files 271 276 +5
Lines 8494 8941 +447
Branches 1134 1212 +78
============================================
+ Hits 3321 3622 +301
- Misses 4754 4872 +118
- Partials 419 447 +28
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Automatically de-duplicate rules when loading rules. When there are duplicate
FlowRuleorDegradeRule, it might not work as expected.Does this pull request fix one issue?
NONE
Describe how you did it
This PR does not contain breaking changes for public methods or interfaces.
loadRulesandregister2Propertymethod. We only de-duplicate the rules internally.setRulesForResourceto support replace rules for a specific resource, while others remain unchanged.Describe how to verify it
Run the test cases.
Special notes for reviews
NONE