Skip to content

Support passing acquireCount and parameters to entry via SentinelReactorSubscriber - #630

Merged
sczyh30 merged 2 commits into
masterfrom
bug/reactor-entry-type
Apr 4, 2019
Merged

Support passing acquireCount and parameters to entry via SentinelReactorSubscriber#630
sczyh30 merged 2 commits into
masterfrom
bug/reactor-entry-type

Conversation

@sczyh30

@sczyh30 sczyh30 commented Mar 29, 2019

Copy link
Copy Markdown
Member

Describe what this PR does / why we need it

Support passing acquireCount and parameters to entry via SentinelReactorSubscriber.

Also fixed the bug that entry type did not take effect in SentinelReactorSubscriber.

Does this pull request fix one issue?

Fixes #629

Describe how you did it

Modify SentinelReactorSubscriber#entryWhenSubscribed to carry the provided entry type, acquireCount and parameters.

Describe how to verify it

Run the WebFlux demo. Virtual inbound traffic node should appear in the metrics log.

Special notes for reviews

NONE

…ected entry type

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30 sczyh30 added the to-review To review label Mar 29, 2019
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30 sczyh30 changed the title Fix the bug of entry type in SentinelReactorSubscriber Support passing acquireCount and parameters to entry via SentinelReactorSubscriber Apr 2, 2019
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #630 into master will increase coverage by 0.47%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #630      +/-   ##
============================================
+ Coverage     40.06%   40.53%   +0.47%     
- Complexity     1292     1305      +13     
============================================
  Files           284      284              
  Lines          8916     8920       +4     
  Branches       1192     1193       +1     
============================================
+ Hits           3572     3616      +44     
+ Misses         4886     4835      -51     
- Partials        458      469      +11
Impacted Files Coverage Δ Complexity Δ
...el/adapter/reactor/SentinelReactorTransformer.java 81.81% <100%> (ø) 4 <0> (ø) ⬇️
...sentinel/adapter/reactor/FluxSentinelOperator.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...nel/adapter/reactor/SentinelReactorSubscriber.java 80% <100%> (+0.33%) 19 <1> (ø) ⬇️
...sentinel/adapter/reactor/MonoSentinelOperator.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...baba/csp/sentinel/adapter/reactor/EntryConfig.java 86.95% <83.33%> (-3.05%) 9 <5> (+2)
...a/csp/sentinel/slots/statistic/base/LongAdder.java 34.04% <0%> (+17.02%) 11% <0%> (+7%) ⬆️
...a/csp/sentinel/slots/statistic/base/Striped64.java 60.41% <0%> (+34.37%) 10% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 015c87c...dab96c8. Read the comment docs.

@sczyh30 sczyh30 added this to the 1.6.0 milestone Apr 2, 2019

@CarpenterLee CarpenterLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entry in SentinelReactorSubscriber does not carry expected entry type

3 participants