Support passing acquireCount and parameters to entry via SentinelReactorSubscriber - #630
Merged
Conversation
…ected entry type Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
============================================
+ Coverage 40.06% 40.53% +0.47%
- Complexity 1292 1305 +13
============================================
Files 284 284
Lines 8916 8920 +4
Branches 1192 1193 +1
============================================
+ Hits 3572 3616 +44
+ Misses 4886 4835 -51
- Partials 458 469 +11
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Support passing acquireCount and parameters to entry via SentinelReactorSubscriber.
Also fixed the bug that entry type did not take effect in
SentinelReactorSubscriber.Does this pull request fix one issue?
Fixes #629
Describe how you did it
Modify
SentinelReactorSubscriber#entryWhenSubscribedto carry the provided entry type, acquireCount and parameters.Describe how to verify it
Run the WebFlux demo. Virtual inbound traffic node should appear in the metrics log.
Special notes for reviews
NONE