Add unit tests for com.alibaba.csp.sentinel.util - #651
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
============================================
+ Coverage 40.41% 40.62% +0.21%
- Complexity 1187 1320 +133
============================================
Files 267 284 +17
Lines 7852 8923 +1071
Branches 1062 1193 +131
============================================
+ Hits 3173 3625 +452
- Misses 4281 4843 +562
- Partials 398 455 +57
Continue to review full report at Codecov.
|
sczyh30
requested changes
Apr 8, 2019
added 2 commits
April 8, 2019 14:01
This test was written using Diffblue Cover.
These tests were written using Diffblue cover.
paulkennethkent
force-pushed
the
add-unit-test
branch
from
April 8, 2019 13:03
617626d to
6c89e13
Compare
Member
|
Thanks! |
blindpirate
pushed a commit
to blindpirate/Sentinel
that referenced
this pull request
Apr 10, 2019
* Add unit test for com.alibaba.csp.sentinel.util.IdUtil * Add unit tests for com.alibaba.csp.sentinel.util.StringUtil
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
…s for acl feature. (alibaba#651) * [ISSUE#403] fix acl config file watch bug,clean and optimize the codes for acl feature. * [ISSUE#403] fix acl config file watch bug,clean and optimize the codes for acl feature. * [ISSUE#403]fix lock/unlock issue,and optimize the codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was written using Diffblue Cover.
Describe what this PR does / why we need it
I've analysed your code base and noticed that
com.alibaba.csp.sentinel.util.IdUtilandcom.alibaba.csp.sentinel.util.StringUtilare not fully tested.Describe how you did it
I've written some tests for the functions in this class with the help of Diffblue Cover. Hopefully, these tests should help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other particular classes that you consider important.