Add SPI precedence support and apply for transport SPI - #675
Merged
Conversation
…ighest precedence Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…tance with highest precedence Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
added
kind/enhancement
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
============================================
- Coverage 41.04% 40.84% -0.21%
- Complexity 1212 1216 +4
============================================
Files 267 267
Lines 7854 7911 +57
Branches 1062 1072 +10
============================================
+ Hits 3224 3231 +7
- Misses 4234 4288 +54
+ Partials 396 392 -4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Add
@SpiOrdersupport and apply precedence support for transport SPI (CommandCenter,HeartbeatSender).Does this pull request fix one issue?
NONE
Describe how you did it
@SpiOrderannotation to indicate precedence. Also updateSpiLoaderto support get the SPI with the highest precedence.CommandCenter,HeartbeatSender). Two providers now will choose the instance with the highest precedence.Describe how to verify it
Run a demo, put with two different transport modules, then see whether the SPI of higher order is activated.
Special notes for reviews
NONE