fix too many connection of zookeeper datasource - #788
Merged
sczyh30 merged 19 commits intoJun 27, 2019
Conversation
added 5 commits
May 9, 2019 14:54
using the LongAdder rather than AtomicInteger to Provides better performance
Codecov Report
@@ Coverage Diff @@
## master #788 +/- ##
============================================
+ Coverage 42.08% 42.27% +0.18%
- Complexity 1411 1420 +9
============================================
Files 307 307
Lines 8868 8897 +29
Branches 1200 1204 +4
============================================
+ Hits 3732 3761 +29
+ Misses 4679 4678 -1
- Partials 457 458 +1
Continue to review full report at Codecov.
|
sczyh30
requested changes
Jun 5, 2019
merge online
Member
|
Friendly ping :) |
merge onlie
…okeeper-datasource
sczyh30
reviewed
Jun 24, 2019
sczyh30
left a comment
Member
There was a problem hiding this comment.
Could you please add some basic test cases?
Collaborator
Author
|
test cases had added |
Collaborator
Author
|
friendly ping :) |
sczyh30
reviewed
Jun 26, 2019
Member
|
Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Fix "too many connections of zookeeper datasource"
Does this pull request fix one issue?
Related to #612
Describe how you did it
Save zkClient in a global map and reuse it
Describe how to verify it
echo cons | nc zookeeper.host 2181Special notes for reviews