Add support for parsing cookie as request items in gateway flow control - #814
Merged
Conversation
- Add `getCookieValue` method in RequestItemParser interface and update GatewayParamParser - Add cookie parsing logic for Spring Cloud Gateway and Zuul Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
============================================
+ Coverage 41.71% 41.75% +0.04%
- Complexity 1376 1379 +3
============================================
Files 304 304
Lines 8764 8784 +20
Branches 1182 1184 +2
============================================
+ Hits 3656 3668 +12
- Misses 4662 4669 +7
- Partials 446 447 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Zhao sczyh16@gmail.com
Describe what this PR does / why we need it
Support parsing cookie as request items in gateway flow control.
Does this pull request fix one issue?
Resolves #813
Describe how you did it
getCookieValuemethod inRequestItemParserinterface and updateGatewayParamParserwith the logicDescribe how to verify it
Run the test cases.
Special notes for reviews
NONE