Fix the numeric overflow bug of ping response data in the cluster module - #844
Merged
Conversation
- this change is compatible with old versions Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #844 +/- ##
============================================
+ Coverage 41.73% 41.82% +0.08%
- Complexity 1383 1389 +6
============================================
Files 305 305
Lines 8807 8810 +3
Branches 1188 1190 +2
============================================
+ Hits 3676 3685 +9
+ Misses 4677 4670 -7
- Partials 454 455 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Zhao sczyh16@gmail.com
Describe what this PR does / why we need it
Fix the bug that the ping response data (of
bytetype) in the default cluster transport implementation might overflow.Does this pull request fix one issue?
Fixes #843
Describe how you did it
Change type of cluster ping data response from
bytetoint. BothPingResponseDataWriterandPingResponseDataDecoderhave been modified.The
PingResponseDataDecoderwill be compatible with old versions:byte.Describe how to verify it
Run the test cases.
Special notes for reviews
NONE