Fix the problem that dashboard do not correctly show the SystemRule in CPU usage strategy - #927
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
============================================
- Coverage 42.54% 42.53% -0.02%
Complexity 1441 1441
============================================
Files 310 310
Lines 8993 8993
Branches 1222 1222
============================================
- Hits 3826 3825 -1
- Misses 4698 4699 +1
Partials 469 469
Continue to review full report at Codecov.
|
Member
|
Thanks for contributing! I'll refine the code later. |
sczyh30
added a commit
that referenced
this pull request
Jul 23, 2019
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
added a commit
that referenced
this pull request
Jul 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it fix the bug that dashboard do not correctly show the system rule(the rule about properties highestCpuUsage)
Does this pull request fix one issue?
Fixes #905
Describe how you did it
I add new properties in entity SystemRuleEntity
I update the related js and html about System rule
Describe how to verify it
Special notes for reviews
i recreate my branch to slove my commit problem of my git account,the previous pull pull922