Conversation
|
|
|
🔍 OpenCodeReview found 2 issue(s) in this PR.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if k == "stream" { | ||
| continue | ||
| stream, isBool := v.(bool) | ||
| if !isBool || stream { | ||
| continue | ||
| } | ||
| } |
There was a problem hiding this comment.
The comment on lines 1301-1304 says "Drop the key rather than forward it", but the code now forwards stream: false to the API. The comment should be updated to reflect the new conditional behavior, e.g.: "Drop the key when it would trigger SSE (non-boolean or true); forward explicit false so callers can override a default."
| if k == "stream" { | ||
| continue | ||
| stream, isBool := v.(bool) | ||
| if !isBool || stream { | ||
| continue | ||
| } | ||
| } |
There was a problem hiding this comment.
Same stale comment issue as in the Anthropic client: the comment says "Drop the key rather than forward it" but the code now conditionally forwards stream: false. Update the comment to match the new behavior.
|
@Rapeter Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. |
This branch has not been deployed
3 participants
Summary
extra_body.stream: falsefor non-streaming OpenAI Chat Completions, Anthropic Messages, and OpenAI Responses requests.stream: true, non-boolean stream values, and OpenAIstream_optionswhere they are not valid.Fixes #1527
Testing
go test -count=1 -run 'TestOpenAIClient_NonStreamingRequestDropsStreamField|TestAnthropicClient_ExtraBodyStreamDropped|TestAnthropicClient_ExtraBodyStreamFalseForwarded|TestOpenAIResponsesClient_ExtraBodyStreamDropped|TestOpenAIResponsesClient_ExtraBodyStreamFalseForwarded' ./internal/llmgo vetandgit diff --check: passed.ocr review --audience agent --background ...: attempted but could not run because no LLM endpoint is configured in the local environment.make testcould not run on this Windows environment because of the existing shell/runtime compatibility issue.AI disclosure
Prepared with OpenAI Codex (GPT-5). I reviewed every changed line and understand the behavior and test coverage.