Repository navigation
feat(ui): add Polish (pl) localization - #626
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b09697c72d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@greptileai review |
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
Upstream added Polish as a ninth catalogue (alphaXiv#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com>
…566) * Show and honour the GitHub owner when enabling repository syncing Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com> * Address review: refresh the GitHub account and keep repository-creation errors The account lookup could stay missing after signing in. The new-project form caches the account login, including a null one from before sign-in, for five minutes, and checking or completing `gh auth login` refreshed only the Git status. A sign-in check now also refetches the account once GitHub reports it is authenticated. When a finished lookup has no login, the personal destination reads "Account unavailable" and a Retry button refetches it, instead of "Resolving account…" with no way forward. The organization guidance from a failed repository creation never reached the user: a message containing "403" or "permission denied" was replaced by the generic push-permission text, dropping the organization name and the SAML SSO advice. Messages starting "GitHub denied repository creation" are now shown as written, and the Rust test pins that prefix. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com> * Add Polish translations for the new strings Upstream added Polish as a ninth catalogue (#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com> * Consolidate publishing settings and choose repository owners per project * Choose replacement repository owners for imported projects --------- Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com> Co-authored-by: Daniel Kim <sox8502@gmail.com>
* Add a History view of experiment lineage and run attempts Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com> * Address review: archived filter, overlay focus, fold counts and narrow layout 1. History ignored "Show archived experiments". App now passes the setting, and History hides archived experiments unless it is on while still building lineage from every experiment, so a shown child of an archived parent keeps its "from ..." lead-in. When every experiment in scope is archived, History shows the same hint as the table. 2. In a narrow view the detail pane covered the list but focus stayed on a covered row. The covered list is now inert until the pane closes, and the pane takes focus when it covers the list. Closing it still returns focus to the row. 3. A folded branch counted later same-chapter experiments reached through another chapter, which also render as their own roots. The fold now follows the same in-chapter children the layout draws. 4. Search could fold a side branch holding a match. Nothing folds while a search is active. 5. The From column stayed at compact widths. It now follows the compact rule like Attempts and Latest. 6. Chapter headers kept status counts and dates on one line at compact widths, squeezing the title. The summary is dropped at compact widths. The width rules move into historyFit() in the model so they can be tested without a browser. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com> * Add Polish translations for the new strings Upstream added Polish as a ninth catalogue (#626), so the strings this change introduces need a Polish entry for the catalogue lint to pass. Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com> * Integrate lineage into experiment table and overview * Trim trailing whitespace in lineage component * Hide experiment lineage by default * Preserve tab gestures in experiment lineage links --------- Co-authored-by: lc140159_gsk <211554985+lc140159_gsk@users.noreply.github.com> Co-authored-by: Daniel Kim <sox8502@gmail.com>
Summary
Add complete Polish (
pl) localization to the OpenResearch UI.Closes #625.
Changes
ui/messages/pl.jsonwith 1,288 translated messages, matching every English catalog key and preserving named interpolation placeholders.ui/project.inlang/settings.json.plin early browser/system language detection (pl-PLresolves topl), keeping the saved language preference behavior.ui/dist, as required by the repository's contribution guidelines.Verification
The fork's GitHub Actions run completed successfully:
pnpm lint:i18n— catalog completeness and placeholder validationpnpm test— UI unit testspnpm build— TypeScript checks and Vite production buildOnly Polish localization sources and their regenerated UI bundle are included in the final diff.
Happy to incorporate feedback on Polish terminology or phrasing.
Final revision verification
Corrected the Slurm duration examples (
4h,30m), Polish count/case grammar and technical wording, demo attribution, and the storage-move warning. Embedded assets were rebuilt.pnpm build, catalog validation, typecheck, all 255 UI tests, style/dev-slot/chart/release-note checks.Screenshots: Polish settings, Slurm save, narrow demo tour. Video capture is unavailable.