Repository navigation
Explain OpenResearch runs lost before the remote runner starts (OR-634) - #804
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
[Medium impact] The PR appears safe to merge; the follow-up fixes the false startup claim. SummaryThe PR explains leased runs lost before their remote supervisor starts.
The follow-up addresses the previous finding: an unknown SSH outcome no longer becomes a claim that the run never started. Reviews (2) · Last reviewed commit: "Only claim a lost run never started when..." · Reviewed by Greptile |
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
@greptileai review — re-review after f4c0ac5 (only claim 'never started' when the supervisor was seen dying). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OR-634.
Summary
On a leased OpenResearch rental,
rental::launchstartedorx rental-supervisein the background and returned right away. If that remote supervisor exits before it claims the launch (on Massed Compute it hits the unwritable~/.config, see OR-589 / #766), nothing activates the lease. The run then showsrunningwith an empty log until the provider releases the box. After that it endslost, andorx exp statusgives no reason, becauseRun::failure_detailonly printed reasons forfailedruns.src/jobs/rental.rs: the launch command now writessupervisor.pid. Launch then waits up to ~10 s forlaunch_started. If the supervisor has exited with output and never claimed the launch, launch fails withSUPERVISOR_EXITEDplus the tail ofsupervisor.log, and the normal launch retries run. A retry is safe because nolaunch_startedmarker exists yet. A supervisor that is still running, or one that exited silently because another supervisor holds the lock, still counts as launched.src/commands/supervise.rs: if a leased run endslostand its last launch attempt failed withSUPERVISOR_EXITED, the run recordsOutcome unavailable: the run never started on box <id>: <error>. Other launch errors, such as SSH drops where the outcome is unknown, keep the watcher's reason.src/plane.rs:failure_detailnow printsreason:forlostruns as well asfailedones.orx exp status,orx exp waitandorx runsall use it.Not in this PR: the fix for the remote config-dir failure itself (#766 / OR-589) and the unreachable-host deadline (#796 / OR-628).
Recordings
Both runs used the same flow. Claude Code in the dashboard ran
orx exp run <id> --backend openresearch --flavor rtx_a6000 --disk 80 --timeout 2hagainst a box whose~/.configis unwritable.On main, the run went starting → running → lost, with no
reason:line and no log:After the fix, the launch retries report the dead supervisor. When the box is released,
orx exp statusandorx runsprint:Test plan
cargo fmt --check,cargo clippy --locked -- -D warningscargo test --locked. New tests:startup_check_reports_a_supervisor_that_died_before_launchandlost_run_reports_its_recorded_reason. Threelocal::projectstests also fail on unmodifiedmainin this VM, because of its git environment.Repro environment: Linux; a local SSH box with an unwritable
/home/Ubuntu/.config; a local stand-in for the openresearch.sh sandbox/lease API that releases unactivated boxes after 5 minutes; the real Claude Code agent. No real GPU provider was used.Automation improvements
CODEX_AUTH_JSON("Provided authentication token is expired"). Refreshing that secret would let Codex-based repros run.Link to Devin session: https://app.devin.ai/sessions/93dec1fe602c46ec8b92a1e5f1c86ec3
Open in Devin Desktop: https://app.devin.ai/desktop/session/93dec1fe602c46ec8b92a1e5f1c86ec3?variant=devin