Repository navigation
fix: retry npm peer resolution conflicts - #4
Conversation
Reviewer's GuideImplements an npm upgrade fallback that retries global installs with --legacy-peer-deps only on ERESOLVE failures, adds regression test coverage for this behavior, and bumps the project to version 2.0.1 with corresponding README and changelog updates, including aligning self-update tests and fixtures with the new version. Sequence diagram for npm global upgrade retry with legacy peer depssequenceDiagram
actor User
participant UpdatesCLI
participant npm
User->>UpdatesCLI: run node updates
UpdatesCLI->>npm: npm install -g global_packages
npm-->>UpdatesCLI: error ERESOLVE
alt ERESOLVE failure
UpdatesCLI->>npm: npm install -g global_packages --legacy-peer-deps
npm-->>UpdatesCLI: success
else other npm failure
UpdatesCLI-->>User: propagate npm error
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new npm ERESOLVE test stubs
npmby matching the full$*string exactly; consider making the match a bit more flexible (e.g., checking for the subcommand and flags with a pattern) so the test won’t become fragile if the argument order or extra flags change in the implementation. - Version strings (e.g.,
2.0.1/2.0.2) are repeated across tests and docs; introducing a single source of truth or helper in the test harness for the current and next release versions would make future bumps less error-prone.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new npm ERESOLVE test stubs `npm` by matching the full `$*` string exactly; consider making the match a bit more flexible (e.g., checking for the subcommand and flags with a pattern) so the test won’t become fragile if the argument order or extra flags change in the implementation.
- Version strings (e.g., `2.0.1` / `2.0.2`) are repeated across tests and docs; introducing a single source of truth or helper in the test harness for the current and next release versions would make future bumps less error-prone.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@coderabbitai review |
There was a problem hiding this comment.
⚠️ Not ready to approve
The new mktemp usage in run_npm_global_install is not reliably portable across Linux environments (e.g., BusyBox), which can silently skip the intended ERESOLVE fallback behavior.
Pull request overview
This PR tightens the node module’s global npm upgrade behavior by retrying only peer-resolution failures (ERESOLVE) with --legacy-peer-deps, while keeping other npm failures strict, and prepares the 2.0.1 patch release across version metadata, docs, and tests.
Changes:
- Add a dedicated
run_npm_global_installwrapper that detectsERESOLVEand retries with--legacy-peer-deps. - Bump release/version references to
2.0.1(Bash + PowerShell entrypoints, docs, changelog). - Add regression coverage for the
ERESOLVEretry behavior and adjust self-update fixtures accordingly.
File summaries
| File | Description |
|---|---|
updates-main.ps1 |
Bumps Windows PowerShell entrypoint version to 2.0.1. |
updates |
Bumps UPDATES_VERSION and adds npm ERESOLVE retry wrapper used by the node module. |
tests/test_cli.sh |
Adds ERESOLVE retry regression test; updates self-update fixture versions for new baseline. |
README.md |
Updates contract/version references and Windows install snippet to 2.0.1 / 2.0.x. |
CHANGELOG.md |
Documents the 2.0.1 patch release and the ERESOLVE retry fix. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 1
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
| Filename | Overview |
|---|---|
| updates | Adds run_npm_global_install helper that captures npm stderr, detects ERESOLVE, and retries with --legacy-peer-deps; version bumped to 2.0.1. Logic is correct across JSON and non-JSON modes. |
| updates-main.ps1 | Adds Invoke-NpmGlobalInstall that mirrors the shell-side ERESOLVE detection using $installResult.Output -match 'ERESOLVE' (which covers both stdout+stderr); version bumped to 2.0.1. |
| tests/test_cli.sh | Adds two ERESOLVE regression tests (success-with-retry and retry-also-fails) and converts self-update version literals to symbolic constants for maintainability. |
| tests/test_windows_native.ps1 | Adds Windows ERESOLVE retry test, introduces $currentReleaseVersion/$previousReleaseVersion constants, and threads $script:UpdatesVersion = $previousReleaseVersion into self-update tests so they correctly simulate upgrading from 2.0.0 to 2.0.1. |
| tests/helpers/windows_test_lib.ps1 | Default $Version parameter for Install-RepoWindowsRuntime bumped from 2.0.0 to 2.0.1 to track the current release. |
| install-windows.ps1 | Default $Version parameter bumped to 2.0.1; no functional change to installer logic. |
| CHANGELOG.md | Adds 2.0.1 release entry documenting the ERESOLVE fallback fix. |
| README.md | Updates version references from 2.0.0 to 2.0.1 and relaxes contract language from pinned version to v2.0.x family. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[module_node / Invoke-ModuleNode] --> B{DRY_RUN?}
B -- yes --> C[log DRY RUN and return 0]
B -- no --> D[run ncu to get outdated packages]
D --> E{packages empty?}
E -- yes --> F[log up-to-date and return 0]
E -- no --> G[run_npm_global_install / Invoke-NpmGlobalInstall]
G --> H["npm install -g -- pkgs\n(stderr captured to temp log)"]
H --> I{exit code 0?}
I -- yes --> J[replay any captured warnings to stderr\nclean up temp file\nreturn 0]
I -- no --> K{ERESOLVE in captured stderr?}
K -- no --> L[replay stderr\nclean up temp file\nreturn npm exit code FAIL]
K -- yes --> M["warn: retrying with --legacy-peer-deps\nreplay captured stderr\nclean up temp file"]
M --> N["npm install -g --legacy-peer-deps -- pkgs\n(via run wrapper)"]
N --> O{exit code 0?}
O -- yes --> P[return 0 OK]
O -- no --> Q[return exit code FAIL]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[module_node / Invoke-ModuleNode] --> B{DRY_RUN?}
B -- yes --> C[log DRY RUN and return 0]
B -- no --> D[run ncu to get outdated packages]
D --> E{packages empty?}
E -- yes --> F[log up-to-date and return 0]
E -- no --> G[run_npm_global_install / Invoke-NpmGlobalInstall]
G --> H["npm install -g -- pkgs\n(stderr captured to temp log)"]
H --> I{exit code 0?}
I -- yes --> J[replay any captured warnings to stderr\nclean up temp file\nreturn 0]
I -- no --> K{ERESOLVE in captured stderr?}
K -- no --> L[replay stderr\nclean up temp file\nreturn npm exit code FAIL]
K -- yes --> M["warn: retrying with --legacy-peer-deps\nreplay captured stderr\nclean up temp file"]
M --> N["npm install -g --legacy-peer-deps -- pkgs\n(via run wrapper)"]
N --> O{exit code 0?}
O -- yes --> P[return 0 OK]
O -- no --> Q[return exit code FAIL]
Reviews (9): Last reviewed commit: "fix: retry npm peer resolution conflicts" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
Warning Review limit reached
More reviews will be available in 25 minutes and 14 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughReleases version 2.0.1 with a targeted fix: a new Changesnpm ERESOLVE Retry Fix — v2.0.1
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f89da4e30b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f89da4e to
43d2e6d
Compare
|
Addressed Sourcery feedback:
@coderabbitai review |
|
✅ Action performedReview finished.
|
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "=== PR Details ==="
gh pr view 4 --repo amanthanvi/updates --json title,body,files,additions,deletions,commits
echo ""
echo "=== PR Diff ==="
gh pr diff 4 --repo amanthanvi/updatesLength of output: 16085 CodeRabbit Review — PR
|
| Item | Status |
|---|---|
ERESOLVE detection via grep on captured stderr |
✅ Correct |
| Temp-file cleanup in all code paths | ✅ Clean |
mktemp portability (2>/dev/null || mktemp -t) |
✅ Portable (Linux & macOS) |
JSON-mode redirect (1>&2 2>"$npm_err_log") |
✅ Intentional and correct |
| Self-update fixture version bumps (2.0.1 → 2.0.2) | ✅ Consistent with new current version |
Version string consistency (updates, updates-main.ps1, CHANGELOG, README) |
✅ |
| New ERESOLVE regression test assertions | ✅ Correct |
warn message matched by test grep |
✅ |
The dry-run bypass is the only functional bug; the rest are test-coverage and doc hygiene.
✅ Action performed
Full review finished.
|
| Filename | Overview |
|---|---|
| updates | Adds run_npm_global_install helper that captures npm stderr to a tempfile, detects ERESOLVE, and retries with --legacy-peer-deps; version bumped to 2.0.1. Two minor concerns: initial npm call bypasses the run wrapper (dry-run relies on module_node's guard), and stderr output ordering could be confusing. |
| tests/test_cli.sh | Adds ERESOLVE retry regression test; bumps self-update fixture target versions from 2.0.1 → 2.0.2 to stay ahead of the new installed version (2.0.1). Logic is correct. |
| CHANGELOG.md | Adds 2.0.1 entry documenting the ERESOLVE fallback fix. Correctly dated and formatted. |
| README.md | Updates version references from 2.0.0 to 2.0.1 and switches the release contract line to v2.0.x. Historical 'removed in v2.0.0' notes are intentionally left unchanged. |
| updates-main.ps1 | Single-line version bump from 2.0.0 to 2.0.1 to keep the PowerShell entry-point in sync. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[module_node] -->|DRY_RUN=1| B[log DRY RUN, return 0]
A -->|DRY_RUN=0| C[ncu_run_json_upgraded]
C -->|no upgrades| D[log up-to-date, return 0]
C -->|upgrades found| E[run_npm_global_install packages]
E --> F{mktemp succeeds?}
F -->|no| G[run npm install -g via run wrapper]
F -->|yes| H{JSON=1?}
H -->|yes| I[npm install -g 1>&2 2>npm_err_log]
H -->|no| J[npm install -g 2>npm_err_log]
I --> K{status=0?}
J --> K
K -->|yes| L[rm tempfile, return 0]
K -->|no| M{grep ERESOLVE in log?}
M -->|no| N[emit stderr, rm tempfile, return status]
M -->|yes| O[emit stderr, rm tempfile, warn retrying]
O --> P[run npm install -g --legacy-peer-deps]
P -->|success| Q[return 0]
P -->|failure| R[return non-zero]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[module_node] -->|DRY_RUN=1| B[log DRY RUN, return 0]
A -->|DRY_RUN=0| C[ncu_run_json_upgraded]
C -->|no upgrades| D[log up-to-date, return 0]
C -->|upgrades found| E[run_npm_global_install packages]
E --> F{mktemp succeeds?}
F -->|no| G[run npm install -g via run wrapper]
F -->|yes| H{JSON=1?}
H -->|yes| I[npm install -g 1>&2 2>npm_err_log]
H -->|no| J[npm install -g 2>npm_err_log]
I --> K{status=0?}
J --> K
K -->|yes| L[rm tempfile, return 0]
K -->|no| M{grep ERESOLVE in log?}
M -->|no| N[emit stderr, rm tempfile, return status]
M -->|yes| O[emit stderr, rm tempfile, warn retrying]
O --> P[run npm install -g --legacy-peer-deps]
P -->|success| Q[return 0]
P -->|failure| R[return non-zero]
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
updates:675-708
**`run_npm_global_install` bypasses the `run` wrapper for its first attempt**
The initial `npm install` call invokes `npm` directly instead of going through `run`, breaking the pattern every other module uses. `run` handles three things: debug logging (manually replicated here), `DRY_RUN` gating (currently covered by the guard in `module_node` at line 2630, but not enforced inside this function), and JSON-mode stdout routing (manually replicated). If `run_npm_global_install` is ever called from a second module or utility that doesn't first gate on `DRY_RUN`, real package installs will fire even under `--dry-run`.
### Issue 2 of 2
updates:683-686
**Stderr is silently buffered; ERESOLVE output appears before the retry notice**
Because `npm stderr` is captured to `$npm_err_log` and then replayed via `cat … >&2` before ERESOLVE is detected, the user always sees the raw npm error block first, followed by the "retrying with --legacy-peer-deps" warning. During a long install this also means all npm warnings are delayed until after npm exits. Consider printing the "retrying" notice before re-emitting the error block so the sequence reads: retry notice → buffered error, making it clearer that the failure was already handled.
Reviews (2): Last reviewed commit: "fix: retry npm peer resolution conflicts" | Re-trigger Greptile
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@updates`:
- Around line 675-708: In the run_npm_global_install function, the npm install
commands at lines 684-687 are called directly without using the run wrapper
function, which bypasses the DRY_RUN check. This causes actual npm installs to
execute even in dry-run mode. Fix this by wrapping the npm install -g commands
with the run function (similar to how line 702 correctly does this with the
legacy-peer-deps retry), ensuring that DRY_RUN mode is properly respected
throughout the function. The conditional logic for JSON output should be
preserved while ensuring the command goes through the run wrapper.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: bcd52876-cb91-4941-9a4e-868fe8ea9171
📒 Files selected for processing (5)
CHANGELOG.mdREADME.mdtests/test_cli.shupdatesupdates-main.ps1
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Greptile Review
🧰 Additional context used
📓 Path-based instructions (4)
**/updates
📄 CodeRabbit inference engine (AGENTS.md)
**/updates: Don't print success messages for failed commands in the updates script
Add new functionality as a module function (module_<name>()) and register it inis_module_known(),module_description(),list_modules(), andrun_selected_modules()
Modules must be auto-detected and skip gracefully if the backing command is missing, unless--onlyis used (then missing deps are an error)
For--jsoncontract: stdout must be JSONL-only; route human output to stderr
KeepUPDATES_VERSIONinupdatesaligned with the latest release tag
Useconfig_set_boolfor adding boolean config keys in the updates script
Files:
updates
**/CHANGELOG.md
📄 CodeRabbit inference engine (AGENTS.md)
Add a
CHANGELOG.mdentry for each release
Files:
CHANGELOG.md
**/*.sh
📄 CodeRabbit inference engine (AGENTS.md)
**/*.sh: Validate scripts using./scripts/lint.shwhich runsbash -n,shellcheck, andshfmt -d
Assume Bash 3.2 compatibility (macOS system Bash); avoid Bash 4+ features
Prefer--dry-runsupport for anything that might mutate state
Start every logical section with a triple-hash banner:### SECTION: <name> — <description>
Files:
tests/test_cli.sh
**/tests/**/*.sh
📄 CodeRabbit inference engine (AGENTS.md)
**/tests/**/*.sh: Run tests via./scripts/test.shwhich executes./tests/test_cli.sh
Keep output stable and easy to parse; prefer--no-emojiin tests
Files:
tests/test_cli.sh
🔇 Additional comments (13)
updates (2)
9-9: LGTM!
2666-2666: LGTM!updates-main.ps1 (1)
22-22: LGTM!tests/test_cli.sh (6)
748-763: LGTM!
778-789: LGTM!
803-812: LGTM!
829-841: LGTM!
857-866: LGTM!
936-956: LGTM!CHANGELOG.md (1)
10-14: LGTM!README.md (3)
5-5: LGTM!
32-35: LGTM!
159-159: LGTM!
43d2e6d to
c4d524c
Compare
|
Addressed follow-up review feedback:
@codex review |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "=== Latest PR Diff ==="
gh pr diff 4 --repo amanthanvi/updates
echo ""
echo "=== PR Files Changed ==="
gh pr view 4 --repo amanthanvi/updates --json filesLength of output: 29965
✅ Dry-run semantics — FixedThe ✅
|
c4d524c to
5e28607
Compare
|
Follow-up cleanup pushed:
@codex review |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "=== Latest PR Diff ==="
gh pr diff 4 --repo amanthanvi/updatesLength of output: 31429
The implementation is correct, portable, and well-covered on both Unix and Windows. This is ready to merge. 🎉 [approve] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e28607142
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
5e28607 to
85028c2
Compare
|
Addressed Codex Windows self-update test finding:
@codex review |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "=== Latest PR Diff ==="
gh pr diff 4 --repo amanthanvi/updates
echo ""
echo "=== PR Status ==="
gh pr view 4 --repo amanthanvi/updates --json state,mergeable,reviews,commitsLength of output: 48494
Everything looks correct. The PR is ready to merge. 🎉 [approve] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85028c2e26
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
85028c2 to
f1fd791
Compare
|
Addressed the Codex installer-default finding:
Local pwsh is not installed on this machine, so Windows-native PowerShell tests were not runnable locally. @codex review |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "=== Latest PR Diff ==="
gh pr diff 4 --repo amanthanvi/updates
echo ""
echo "=== PR Status ==="
gh pr view 4 --repo amanthanvi/updates --json state,mergeable,reviews,commitsLength of output: 49743
The implementation is correct, portable, and well-covered on both Unix and Windows. This PR is ready to merge. 🎉 [approve] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1fd791f63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f1fd791 to
a1fbd4e
Compare
|
Addressed the late Codex Windows launcher fixture finding:
Local pwsh is not installed on this machine, so Windows-native PowerShell tests were not runnable locally. @codex review |
|
Correction to the previous comment: shell quoting stripped two inline literals before posting. Addressed the late Codex Windows launcher fixture finding:
Local pwsh is not installed on this machine, so Windows-native PowerShell tests were not runnable locally. @codex review |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "=== Latest PR Diff ==="
gh pr diff 4 --repo amanthanvi/updates
echo ""
echo "=== PR Status ==="
gh pr view 4 --repo amanthanvi/updates --json state,mergeable,reviews,commitsLength of output: 52120
The implementation is correct, portable, and thoroughly covered on both Unix and Windows. This PR is ready to merge. 🎉 [approve] |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "=== Latest PR Diff ==="
gh pr diff 4 --repo amanthanvi/updates
echo ""
echo "=== PR Status ==="
gh pr view 4 --repo amanthanvi/updates --json state,mergeable,reviews,commitsLength of output: 52120
Every item from every review round is addressed. The implementation is correct, portable, and thoroughly covered on both Unix and Windows. This PR is ready to merge. 🎉 [approve] |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
--legacy-peer-depsonly after npm fails withERESOLVE2.0.1and document the patch releaseValidation
./scripts/test.sh./scripts/lint.shbash ./scripts/release-build.sh 2.0.1 /tmp/updates-release-2.0.1-51353bash ./scripts/release-verify-dist.sh 2.0.1 /tmp/updates-release-2.0.1-51353UPDATES_SELF_UPDATE=0 updates --only node --no-emoji --no-colorupdates --only node --no-emoji --no-colorRelease Plan
After review/CI is clean:
main.bash ./scripts/release.sh 2.0.1.mainandv2.0.1tag.dist/.Summary by Sourcery
Implement stricter handling of global npm upgrade failures while adding a targeted fallback for peer resolution conflicts and preparing the 2.0.1 patch release.
Bug Fixes:
Enhancements:
Documentation:
Tests:
Summary by CodeRabbit
--legacy-peer-depsflag when peer dependency resolution fails, improving success rates while maintaining strict error detection for other npm issues.