[BUG] change agentready GHA to run on-demand only

[jeremyeder]

Expose the agentready workflow through slash commands within GitHub comments. For example

/agentready assess https://github.com/ambient-code/agentready

This is the GHA that needs modification:
https://github.com/ambient-code/agentready/blob/main/.github/workflows/agentready-assessment.yml

[jeremyeder]

Triage Update - Needs Clarification ⚠️

Status: Needs Clarification
Current Behavior: .github/workflows/agentready-assessment.yml runs on:

• pull_request (opened, synchronize, reopened)
• push to main/master
• workflow_dispatch (manual trigger)

Questions

1. Why should it be on-demand only? The current triggers are standard CI best practices:

   • PR trigger: Validates changes before merge
   • Push to main: Catches integration issues
   • Manual trigger: On-demand capability already exists

2. What problem are we solving? Is this about:

   • Cost/resource usage?
   • Slow CI times?
   • Failing checks blocking PRs?

3. Proposed alternative? Should we:

   • Keep PR trigger, remove push to main?
   • Add caching/optimization instead?
   • Add slash command support for Claude Code?

Please clarify the motivation and desired behavior before we proceed.

[jeremyeder]

I only want it to run using manual trigger like @agentready-dev assess .

[jeremyeder]

Root Cause Analysis

The feature requested in this issue was already implemented in your fork (jeremyeder/agentready) via "PR #8" (commit 350f21b), but the changes were never pushed to upstream (ambient-code/agentready).

Why workflows were still running on PR/push events:

1. ✅ Your fork's main has the updated on-demand-only workflow
2. ❌ Upstream main still has the OLD workflow with pull_request and push triggers
3. 🔄 Feature branches created from upstream inherit the OLD workflow file
4. 🏃 GitHub Actions runs the workflow from the PR's branch, not the target branch

Result: PRs from upstream-based branches still triggered on every PR/push event.

Resolution

Created PR #209 to push the on-demand workflow changes to upstream.

Once merged, all new feature branches will inherit the on-demand-only workflow and this issue will be fully resolved.

Current Status

• ✅ Fork (jeremyeder/agentready): On-demand only
• ⏳ Upstream (ambient-code/agentready): Pending PR feat: convert AgentReady assessment to on-demand workflow #209
• ⏳ Issue [BUG] change agentready GHA to run on-demand only #191: Will close automatically when PR feat: convert AgentReady assessment to on-demand workflow #209 merges

[jeremyeder]

Update: Conflicts Resolved

New PR created: #213

Changes from previous PR #209:

• ✅ Fixed all shellcheck warnings
• ✅ Used bash parameter expansion instead of sed
• ✅ Proper variable quoting throughout
• ✅ Brace grouping for GITHUB_OUTPUT redirects
• ✅ All pre-commit hooks pass

Ready for review and merge!