Repository navigation
Conversation
|
The Unit tests job failed as infrastructure rather than as a test — the Go compiler was killed while building aws-sdk-go-v2/service/s3 and the runner then received a shutdown signal: The run never reached any test in this PR. The same signature has hit main before (run 12976, commit ae95342). The other 7 Validations jobs are green, as are CodeQL, Validate GitHub Actions and DCO, and go test ./syft/pkg/cataloger/binary/... passes locally. Could someone re-run the failed job? |
The istio pilot-agent/pilot-discovery classifiers missed every -snapshot.N build and the older -alpha.N/-beta.N/-rc.N layouts. Two defects: 1. The doubled-version matcher anchored on a bare x.y.z followed by NULs, but pre-release builds repeat the full version including the suffix (1.15.0-beta.0 NUL NUL NUL 1.15.0-beta.0), so the anchor never matched. Only the capture group had been widened previously. 2. -snapshot.N was absent from every alternation, and snapshot builds store the version only once with no leading copy, so no existing matcher could reach it. Widen the leading anchor to accept the same optional pre-release suffix it already accepts in the capture group, add -snapshot.N to each alternation, and add a matcher for the standalone snapshot layout. The new matcher is second so it can never shadow a normal build. Adds real captured snippets for pilot-agent and pilot-discovery at 1.0.0-snapshot.0, 1.5.0-alpha.0, 1.15.0-beta.0 and 1.19.0-rc.0. Fixes anchore#5060 Signed-off-by: phatlc <phatle.hsd@gmail.com>
bea0653 to
7fc3e81
Compare
|
Gentle ping on this one — it's been open since 29 July. The branch is still green and has no conflicts with main. It is scoped to the istio pilot-agent / pilot-discovery classifiers: the leading anchor of the doubled-version matcher now accepts the same optional pre-release suffix the capture group already accepted, and Happy to rebase, split it, or add cases if any of that would help review. |
The istio pilot-agent/pilot-discovery classifiers missed every -snapshot.N build and the older -alpha.N/-beta.N/-rc.N layouts.
Two defects:
The doubled-version matcher anchored on a bare x.y.z followed by NULs, but pre-release builds repeat the full version including the suffix (1.15.0-beta.0 NUL NUL NUL 1.15.0-beta.0), so the anchor never matched. Only the capture group had been widened previously.
-snapshot.N was absent from every alternation, and snapshot builds store the version only once with no leading copy, so no existing matcher could reach it.
Widen the leading anchor to accept the same optional pre-release suffix it already accepts in the capture group, add -snapshot.N to each alternation, and add a matcher for the standalone snapshot layout. The new matcher is second so it can never shadow a normal build.
Adds real captured snippets for pilot-agent and pilot-discovery at 1.0.0-snapshot.0, 1.5.0-alpha.0, 1.15.0-beta.0 and 1.19.0-rc.0.
Fixes #5060
Description
Type of change
Checklist
Issue references