Translate project to English - #1
Conversation
Localize all code comments, docstrings, user-facing API messages, config defaults, docs (README, AGENTS.md), scripts, and tests to English. - fetch.locale default changed zh -> en - response.data_template default words translated (Rolling/Weekly/Monthly) - user-facing API reason strings translated (404/401 + business errors) - all test assertions updated to match the translated messages - 58 tests pass
|
Thanks for your translation work! My English is not good so i use deepseek to help me review your PR and write this review :) A few adjustments before this can merge: Keep English for all user- and deployer-facing strings (no change needed)This service must be self-hosted (it carries per-account auth cookies), so every operator is also a user. English is correct for: the API response messages (account not found 404, unauthorized 401, the Restore Chinese for maintainer-facing code commentsThe project is maintained in Chinese by me (with limited English proficiency :( ), so please revert the following to Chinese (the original text is preserved in git history on master):
README: bilingual instead of fully EnglishThe fully-English README drops the existing Chinese documentation, which this project wants to keep. Please:
DOM fixture: actually exercise a non-default localeThe PR description says Thanks again, happy to answer any questions. |
Summary
Localizes the entire project to English: code comments, docstrings, user-facing API response messages, configuration defaults, documentation (
README.md,AGENTS.md), shell scripts, and test files.Changes
account not found(404),unauthorized(401), and theservice.pybusiness-failure reasons (auth cookie has expired...,fetch failed: ...,this account has no OpenCode Go subscription,failed to parse usage data from the page...).fetch.localedefaultzh->enresponse.data_templatedefault words translated toRolling / Weekly / Monthlyuv run pytest).Notes
data-slotstructure, not label text), so pages served in any locale still parse correctly.DOM_HTML_ENcovers a non-default-locale page; the Chinese invalid-account-ID test case ("中文") is kept intentionally to verify such IDs are rejected.