Repository navigation
Stop when the call ends is always on; three designs for the call-ended capsule - #1415
Draft
kitlangton wants to merge 1 commit into
Draft
kitlangton wants to merge 1 commit into
kitlangton wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graduates Labs › Stop when the call ends (#835) and redesigns the capsule that counts down to the stop. There are three designs to pick from. Once one is chosen, the other two, the temporary switch and the extra scenes come out, and the goldens get regenerated.
Before: a recording Hex started on its own stopped after its call ended only if the Lab was on. The capsule said "Microsoft Teams left the call" / "Hex stops recording in 30 s unless you keep recording." It had a red dot and no sign of time passing.
After: that recording always stops 30 s after its call ends, unless you keep recording. Recordings you started yourself still never stop on their own. The capsule says "Teams call ended" / "Recording stops in 23 s" and shows the call app's icon, a drain that empties as the seconds pass, and Keep recording / Stop now.
HEX_CALL_ENDED_VARIANT)ring(default)baroutlineThe drain is a render-time tween: it moves every frame without rebuilding the view, the count rebuilds once a second, and the drain fades over its last 0.18 s. Under Reduce Motion it steps once a second with the count.
Scenes:
call-ended-{ring,bar,outline}, plus-mid(12 s left) and-manual(no countdown) versions of each.Read:
src/rune_ui/meeting_capsules/call_ended.rs, then theCallEnded/CallResumedchanges inmeeting/watcher.rsandmeeting_capsules.rs. Themeeting-capsule-call-ended-*goldens are stale until a design is picked, so Linuxpanel_goldenswill fail until then.