Repository navigation
feat(settings): General as six rows and one fold; a simpler Sounds sheet - #1422
Open
kitlangton wants to merge 5 commits into
Open
kitlangton wants to merge 5 commits into
kitlangton wants to merge 5 commits into
Conversation
kitlangton
force-pushed
the
general-hierarchy
branch
2 times, most recently
from
November 5, 2026 21:52
4e0f439 to
54c3731
Compare
kitlangton
force-pushed
the
general-hierarchy
branch
from
November 5, 2026 22:23
54c3731 to
b01ec5b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General now shows the six settings people actually change, with everything else in one fold, and the Sounds sheet is a volume slider and a list.
Layout and copy only: no setting is added, removed or saved differently. Linux and Windows get the same structure.
❌ Before
✅ After
🟰 Behavior change: none to settings. The volume slider moves in 5% steps instead of the old Off/25/50/75/100 menu (same saved number). Releasing at zero turns sounds off and keeps the last volume, as Off did.
📸 General, before / after (fold open)
📸 Sounds, before / after
👀 Read:
src/rune_ui/general.rs, thedisclosuregroups andshown_side(the side control hides while the recorder listens so the recorder takes its place).sound_sets.rslost its HUD preview, sorune_hud'sdraw_overandsound_sets/hud.rsare gone. The rest is copy, translations, tests and goldens.From the November 5 General hierarchy pass · no user reports · Notch HUD, Unload idle, Hide menu bar icon and Vocabulary biasing stay as Labs switches, untouched
Checks run
cargo clippy --locked --workspace --all-targets --features onnx-benchmark -- -D warnings(macOS): cleanscripts/check rune_ui settings i18n feedback(macOS): 472 passedcheck-linux.yml'sgolden-actual, each changed image looked atcheck-linux.yml(nix, Linux clippy, every test, goldens): green