Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
anomalycoorg is on the Team plan, so at most 5 GitHub-hosted macOS jobs run at once, org-wide. Jobs wait hours for a runner. In the last 24 hours, hex used about 1,800 macOS runner-minutes (195 jobs that got a runner), the second-largest share in the org:macOSbuild-macos,sign-macos,verify-macos)macOS arm64Two items overlap on PR branches:
macOSjobs (247 minutes) ran on a commit that also had a Check macOS run. Check macOS runs the samecargo clippy --bin hex -D warnings, plus--lib --tests,fmt, andnextest.concurrencygroup, so a new dispatch on a branch does not cancel the stale run.Change
macos-covered, waits 60 seconds. Then it looks for a non-cancelledworkflow_dispatchCheck macOS run on the PR head SHA. If it finds one, themacOSjob is skipped. If the lookup fails, or if the workflow is dispatched, themacOSjob runs as before.workflow_call(whereinputs.shais set) and dispatches ondevorproductioneach get a unique group (check-macos-run-<run_id>), so they are never cancelled or replaced.Expected impact
macOS: about 33–37 fewer jobs and about 220–250 fewer runner-minutes per day. This is the 37 duplicate jobs, minus the few dispatches that came more than a minute after the push (4 of 52 matched commits).macOScompile starts up to 60 seconds later. Today it waits about 30 minutes for a runner, so the delay is small.Release risk
release.yml,build-desktop.yml,windows-installers.yml, andtest-builds.ymlare unchanged.hex-agent-policy, and this change does not touch it. Compile is not required.cargo fmt --check), the failure is still visible, but clippy did not run for that commit.