Skip to content

fix(desktop): Fixed a reactive feedback loop in the global project cache sync - #10139

Merged
Brendonovich merged 1 commit into
anomalyco:devfrom
Eric-Guo:fix_reactive_loop_project_cache
Jan 23, 2026
Merged

fix(desktop): Fixed a reactive feedback loop in the global project cache sync#10139
Brendonovich merged 1 commit into
anomalyco:devfrom
Eric-Guo:fix_reactive_loop_project_cache

Conversation

@Eric-Guo

@Eric-Guo Eric-Guo commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix #10136, introduce at 14db336

@adamdotdevin

@Eric-Guo
Fixed a reactive feedback loop in the global project cache sync so th…
497af37 
…e cache write no longer retriggers itself, which should stop the stack overflow during resource load. Use untrack when reading the cache length so the effect only depends on the project list + readiness and doesn’t re-fire on its own cache updates.
Copilot AI review requested due to automatic review settings January 23, 2026 03:40
@github-actions

github-actions Bot commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

Copilot AI reviewed Jan 23, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug causing the desktop application to crash on startup with "Maximum call stack size exceeded" error. The issue was caused by a reactive feedback loop between two createEffect blocks that synchronize project data between the global store and persistent cache.

Changes:

  • Added untrack import from solid-js
  • Refactored the project cache sync effect to use untrack when reading cached project length, breaking the reactive dependency cycle while preserving the same logical behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JeffConcerto

JeffConcerto commented Jan 23, 2026

Copy link
Copy Markdown

Nice work, @Eric-Guo! Hope this gets implemented ASAP

@Eric-Guo

Eric-Guo commented Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

@JeffConcerto It's 99.9% done by gpt-5.2-codex xhigh 🤦

@ProdigyRahul

ProdigyRahul commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

@adamdotdevin will wake up and see the 10000 dms about this

@Brendonovich
Brendonovich merged commit b298982 into anomalyco:dev Jan 23, 2026
15 of 16 checks passed
@reneleonhardt

reneleonhardt commented Jan 23, 2026

Copy link
Copy Markdown

Thank you for fixing it!
Would it be possible to add unit tests to prevent such regressions introduced by fixes in the future?

@adamdotdevin

adamdotdevin commented Jan 23, 2026

Copy link
Copy Markdown
Member

Thank you for fixing it!

Would it be possible to add unit tests to prevent such regressions introduced by fixes in the future?

There are e2e tests, will look into why they didn't block release

@favorPotato favorPotato mentioned this pull request Jan 23, 2026
Closed
Copilot AI mentioned this pull request Jan 23, 2026
Closed
xenonwellz pushed a commit to xenonwellz/opencode that referenced this pull request Jan 28, 2026
@Eric-Guo @xenonwellz
fix(desktop): Fixed a reactive feedback loop in the global project ca…
804d508 
…che sync (anomalyco#10139)
@adolago adolago mentioned this pull request Feb 14, 2026
Closed
3 tasks
xywsxp pushed a commit to xywsxp/opencode that referenced this pull request Apr 24, 2026
@Eric-Guo
fix(desktop): Fixed a reactive feedback loop in the global project ca…
909b2a0 
…che sync (anomalyco#10139)
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request May 5, 2026
@Eric-Guo
fix(desktop): Fixed a reactive feedback loop in the global project ca…
dab73a4 
…che sync (anomalyco#10139)
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
@Eric-Guo
fix(desktop): Fixed a reactive feedback loop in the global project ca…
23546c3 
…che sync (anomalyco#10139)
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
@Eric-Guo
fix(desktop): Fixed a reactive feedback loop in the global project ca…
4e0f91c 
…che sync (anomalyco#10139)
avion23 pushed a commit to avion23/opencode that referenced this pull request Jun 10, 2026
@Eric-Guo
fix(desktop): Fixed a reactive feedback loop in the global project ca…
8ca1d7c 
…che sync (anomalyco#10139)
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request Jun 14, 2026
@Eric-Guo
fix(desktop): Fixed a reactive feedback loop in the global project ca…
51fe177 
…che sync (anomalyco#10139)
MarsQiu007 referenced this pull request in MarsQiu007/openNovel Jul 31, 2026
@Eric-Guo
fix(desktop): Fixed a reactive feedback loop in the global project ca…
2045262 
…che sync (#10139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@Brendonovich Brendonovich Brendonovich approved these changes
@adamdotdevin adamdotdevin Awaiting requested review from adamdotdevin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OpenCode Desktop blank in v1.1.33

7 participants

@Eric-Guo @JeffConcerto @ProdigyRahul @reneleonhardt @adamdotdevin @Brendonovich