Skip to content

fix(opencode): log silent auth and provider discovery errors - #34313

Closed
MADEVAL wants to merge 1 commit into
anomalyco:devfrom
CyberSecureAgency:silent-error-logging
Closed

fix(opencode): log silent auth and provider discovery errors#34313
MADEVAL wants to merge 1 commit into
anomalyco:devfrom
CyberSecureAgency:silent-error-logging

Conversation

@MADEVAL

@MADEVAL MADEVAL commented Jun 28, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #34312

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Three catch blocks silently swallowed errors:

  • auth/index.ts discarded invalid OPENCODE_AUTH_CONTENT JSON with no warning, falling through to file-based auth invisibly
  • provider.ts GitLab model discovery returned {} on any failure with no indication the discovery itself failed
  • the outer GitLab discovery caller had a second empty catch block

auth uses Effect.logWarning to surface the parse failure. provider's outer catch is replaced with Effect.catchAll + Effect.logWarning. provider's inner async discoverModels uses console.error since it is outside the Effect runtime.

How did you verify your code works?

Manual verification against repo logging patterns: auth follows the existing config.ts:548 pattern, provider follows workspace.ts:278.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Silent error swallowing hides auth and provider failures

1 participant