fix(session): log summary and prune background task failures - #36361
fix(session): log summary and prune background task failures#363611837620622 wants to merge 2 commits into
Conversation
summary.summarize and compaction.prune are forked with Effect.ignore, so failures disappear with no diagnostics — same silent pattern as title generation before logging was added. Minimal fix: replace Effect.ignore with Effect.catchCause + warning logs at both call sites. Behavior stays non-blocking (still forked).
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
added
needs:issue
needs:compliance
|
Ready for review — same silent-failure class as title gen (#36356), for summary/prune only. — @1837620622 |
Match ensureTitle background logging: do not warn when the forked summary/prune fiber is interrupted-only.
github-actions
Bot
removed
needs:compliance
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
1 similar comment
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Review ping 🙏 Background |
Ported from upstream anomalyco#36361.
Ported from upstream anomalyco#36361.
Gentle follow-upStill ready for review. Logs background Thanks! |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
1 participant
Issue for this PR
Closes #36366
Related: #13710 (same silent-failure class for title generation)
Type of change
What does this PR do?
Background
summary.summarizeandcompaction.pruneare forked withEffect.ignore, so failures produce no logs.Replace
Effect.ignorewithEffect.catchCause+ warning logs (skip interrupt-only causes). Behavior stays non-blocking (still forked).How did you verify your code works?
packages/opencode/src/session/prompt.tsEffect.ignorewith no diagnosticsScreenshots / recordings
N/A — non-UI
Checklist