Skip to content

refactor(app): remove promoting workaround - #36426

Closed
nokados wants to merge 1 commit into
anomalyco:devfrom
nokados:remove-promoting
Closed

refactor(app): remove promoting workaround#36426
nokados wants to merge 1 commit into
anomalyco:devfrom
nokados:remove-promoting

Conversation

@nokados

@nokados nokados commented Jul 11, 2026

Copy link
Copy Markdown

Issue for this PR

N/A — cleanup of workaround from #34466

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Commit e34822d (#34466) added an in-memory promoting state to
bridge the gap between promote() clearing store.draft and
navigate() updating the session ID.

Commit ea982c3 (#36182) wrapped promote() + navigate() in
startTransition, which batches both updates atomically. The
promoting workaround is no longer needed — scope() switches
directly from store.draft to saved.session[session] with no
intermediate state.

How did you verify your code works?

Verified no flicker on both latest and dev Web UI channels when
sending the first message in a new session with a non-default model
selected.

Screenshots / recordings

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant