fix(core): fail empty provider output - #37379
Closed
rasitakyol wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Author
|
The linked issue is #37372 and the PR body contains Closes #37372. This change targets v2 because the affected Session V2 implementation is not present on dev. GitHub does not populate closingIssuesReferences for a PR whose base is not the default branch, so the standards workflow added needs:issue despite the explicit reference. Retargeting to dev would include the unrelated divergent v2 branch. Maintainers: please confirm this is the preferred base and remove the false-positive label, or advise the expected linkage for v2 PRs. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #37372
Type of change
What does this PR do?
Treats a successful provider stream with no visible text or tool call as
provider.invalid-output. This prevents empty or reasoning-only responses from ending the execution as a silent success.The test fixtures that intentionally represent successful turns now include usable text or a completed tool call.
How did you verify your code works?
bun test test/session-runner.test.ts test/session-execution.test.ts --only-failures: 135 tests passed.bun typecheckinpackages/core.git diff --check.Screenshots / recordings
Not applicable; this changes the V2 provider-completion contract and tests.
Checklist