Skip to content

fix(ui) latex dollar render - #38829

Open
8Nothing8 wants to merge 6 commits into
anomalyco:devfrom
8Nothing8:fix-latex-dollar-render
Open

fix(ui) latex dollar render#38829
8Nothing8 wants to merge 6 commits into
anomalyco:devfrom
8Nothing8:fix-latex-dollar-render

Conversation

@8Nothing8

@8Nothing8 8Nothing8 commented Jul 25, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #37326, #38030

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

#34850 intentionally removed bare $...$ math to avoid false positives in currency and code, but its block rule also stopped matching single-line $$...$$.

This PR keeps bare $...$ disabled and adds display-math support for:

  • $$...$$, single or multi-line
  • \[...\], single or multi-line

Existing \(...\) inline math remains unchanged.

How did you verify your code works?

(Verification)

  • bun typecheck in packages/ui
  • bun test in packages/ui (9 passing)

Screenshots / recordings

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

Hey! Your PR title Fix latex dollar render doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Jul 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@8Nothing8 8Nothing8 changed the title Fix latex dollar render fix(ui) latex dollar render Jul 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found a potentially related PR:

Related PR:

This PR is related because it addresses LaTeX display math rendering with \[...\] delimiters, which is one of the features added in the current PR #38829. However, since the current PR (38829) closes issues #37326 and #38030 and extends the math rendering support beyond what #35951 does (adding $$...$$ in addition to \[...\]), this appears to be a follow-up improvement rather than a true duplicate.

No duplicate PRs found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

math equations not rendered

2 participants