fix(provider): parse URL-based provider IDs - #40071
Open
obadakhalili wants to merge 3 commits into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Can confirm as the original reporter that this does seem to fix the issue for me. Still trying to learn how to properly build and install from the branch to do more extensive testing but with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #39926
Type of change
What does this PR do?
parseModeldoes not account for models connected through a well-known gateway. It expectsproviderID/modelID, but fails when the provider ID is itself a URL. Normal prompts work because they send the provider and model IDs separately, while commands combine them into a single string that the server must parse.the PR fixes
parseModelto account for gateway-connected models.How did you verify your code works?
select the gateway model in
/modelssending a prompt works
before fix:
/gateway-testfails with "Model not found"after fix:
/gateway-testsucceedsChecklist