fix(acp): drain updates before end turn - #40422
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17505
Type of change
What does this PR do?
Waits for the backing session to emit its idle status before returning the ACP prompt response. The ACP event subscription processes events sequentially and awaits each
sessionUpdate, so observing idle guarantees earlier message and tool updates have reached the client beforeend_turn.The waiter is registered before starting prompt, command, and summarize requests so an idle event cannot race the HTTP response. Pending turns also fail if the event stream disconnects instead of returning an incorrectly ordered response.
How did you verify your code works?
bun test test/acpfrompackages/opencode(128 pass)bun typecheckfrompackages/opencodebun turbo typecheck(30 packages)Screenshots / recordings
Not applicable.
Checklist