Repository navigation
More type hints for Amazon provider #11297
Description
Description
The boto3 used by Amazon provider generates new classes at runtime, so mypy is not aware of types. Luckily, there is a package that has generated type annotations, but we have to install them separately - boto3-stubs
It would be nice for us to check if this library meets our expectations and integrate it with our CI.
CC: @kaxil @mlgruby @coopergillan
Use case / motivation
This will allow us to detect more problems during the static check. It will also provide a better development experience as the IDE will be able to suggest types.
Related Issues
N/A
Activity
[-]Strict type hints for Amazon[/-][+]More type hints for Amazon[/+][-]More type hints for Amazon[/-][+]More type hints for Amazon provider[/+]mlgruby commentedon Oct 6, 2020
Since you mentioned in last issue comment I had a look and it make sense to try it here.
I can have a look.
kaxil commentedon Oct 6, 2020
Cool, thanks. Not super important, this can wait if you'd like to work on other Type hints first. Completely up to you :)
mlgruby commentedon Oct 6, 2020
Yup, just gonna do some checks and then switch to other type hints 🙂
scrambldchannel commentedon Oct 12, 2020
I'm interested in helping with this too, I was just looking at the AWS provider typehints and came across the same library.
potix2 commentedon Oct 15, 2020
I'm interested in this issue too.
kaxil commentedon Oct 15, 2020
Go for it @potix2 if you would like to create PR, take #11470 as an example
potix2 commentedon Oct 15, 2020
I'm working on #11531. But I feel it's too large to ask for review. Should I divide into some small requests?
kaxil commentedon Oct 18, 2020
Sure got for it
7 remaining items
potix2 commentedon Dec 16, 2020
I'm working on #10742, but it's a little harder than I expected. After complete it, I'll be back to this issue.
coopergillan commentedon Jun 20, 2021
@mik-laj - came back to this after seeing a new comment on an old PR: https://github.com/apache/airflow/pull/10164/files#r653685526
It looks like
boto3_type_annotationsis another option in addition toboto3-stubsas you mention.Do you have a preference? Do you know if either of these have yet been installed? Guessing no.
mik-laj commentedon Jun 20, 2021
boto3_type_annotations is deprecated. We should use boto3-stubs.
Taragolis commentedon Mar 2, 2023
I do not a time and desire to complete this (and other) tasks.
For someone who would like to work on this, implement this one could be nice start point