You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think by now everyone knows the benefit of dark mode.
It would be great if Airflow will offer this open in the UI
I believe it should be setting per user that can be controlled from the user profile.
This is definitely on my radar/wish list as well. With the current UI framework, there isn't a clean and clear path to implement this in a sustainable fashion. The aged Bootstrap (v3.3) dependency nested in our FAB dependency is one of the biggest limitations, whereas the latest Bootstrap versions (v5) employ CSS variables that would allow for systematic approach to theme switching. That said, I'm not ready to take this on at this time, but I'm exploring more significant UI framework changes that would definitely make this easier to accomplish.
No. The AIP is not yet complete. It is in progress and currently airflow is a mixture of old and new UI. Until it is fully converted, dark mode will not happen consistently.
I think it waits for someone to implement it. Generally if there is no comment, about it and UI does not have it, there is no change.
But maybe you want to help with that and provide some PRs @NFeruch if you are eager to have it ? That could speed it up. If not, then it simply has to wait for someone from the community to pick it up. We have > 2200 contributors and anyone could contribute it in forn of PR :). And you could become one of them. This is how OSS works basically.
Reacted by Garrett Marsh, Tong Jin and Victor Coutinho
Please implement this, honestly a button on the main page changing the background to a darker color and the text color to a different one is enough. You can perfect it later.
Reacted by Tong Jin, Pablo Castrejón, Lev Nik, Daniel Pazeto Jr, Matteo Manzi, MartinUQ, septcanards, Enrique (Kike) Fernández-Laguilhoat, ukayani, Stathis Kapnidis and 12 more
Well, maybe one of you would like to take on the task ? I t waits for someone who knows ui to pick it up. As everything in open sources will be implemented when someone implements it :).
Or maybe find someone who could do it of you want it so badly? Anyone can volunteer and implement it actually so if you know someone who knows the ui frameworks and could implement it - convince that someone to volunteer it and it is the fastest way to get it done.
Maybe you would like to volunteer and implement it @bengabp ?
I think this task is waiting for someone who is interested in it an will implement it. you can also find someone who would like to implement it and contribute it. This is how it works for open-source development when you have mostly volunteers contributing. Anyone could contribute it - and finding time or someone who could contribute it is the fastest way to get something you really want.
Reacted by Peter Stone, Inon S. and Jorge Troncoso
I'm not sure if this goes against the philosophy / licensing of Airflow, but I would love to extend this dark mode theme idea into a broader feature set that would enable white labeling. I picked up the idea at a GrafanaLive conference where a presenter showed a dashboard where the color scheme matched the company's color scheme. I think that would be awesome in Airflow.
Yes. It could be done. No licencing or philosophy problem. It just waits for somoene who will implement it. there are always a lot of ideas, but far less number people who will to spend their time and energy (and skils) to contribute implementations of those :)
I have checked out Apache Airflow for the dark mode feature and see that @YounHS implemented the feature. The PR was merged 7hr ago, I love the new feature and will give it a try right now. Thank @YounHS for bringing the great feature to Apache Airflow.
Reacted by SecY, Brian Lu, fatsolko, Guy Boldon, Lucas Paiolla, Túlio Lima and Ilya Dashkovsky
Activity
alxdembo commentedon Dec 15, 2020
@mik-laj Can I volunteer for this one?
mik-laj commentedon Dec 15, 2020
This seems to me not to be a task that one person can do. @ryanahamilton Can you help with this task? Do you have any expectations or suggestions?
ryanahamilton commentedon Dec 18, 2020
This is definitely on my radar/wish list as well. With the current UI framework, there isn't a clean and clear path to implement this in a sustainable fashion. The aged Bootstrap (v3.3) dependency nested in our FAB dependency is one of the biggest limitations, whereas the latest Bootstrap versions (v5) employ CSS variables that would allow for systematic approach to theme switching. That said, I'm not ready to take this on at this time, but I'm exploring more significant UI framework changes that would definitely make this easier to accomplish.
eladkal commentedon Mar 8, 2021
dark mode will be added as part of AIP-38 Modern Web Application
MartinUQ commentedon Aug 2, 2022
So this is done but not in official release ? I can find it in the settings
potiuk commentedon Aug 3, 2022
No. The AIP is not yet complete. It is in progress and currently airflow is a mixture of old and new UI. Until it is fully converted, dark mode will not happen consistently.
NFeruch commentedon Oct 2, 2022
What is the status of this issue as of 10/1/2022?
potiuk commentedon Oct 2, 2022
I think it waits for someone to implement it. Generally if there is no comment, about it and UI does not have it, there is no change.
But maybe you want to help with that and provide some PRs @NFeruch if you are eager to have it ? That could speed it up. If not, then it simply has to wait for someone from the community to pick it up. We have > 2200 contributors and anyone could contribute it in forn of PR :). And you could become one of them. This is how OSS works basically.
m-urminsky commentedon Dec 20, 2022
Please implement this, honestly a button on the main page changing the background to a darker color and the text color to a different one is enough. You can perfect it later.
MartinUQ commentedon Dec 20, 2022
My eyes are hurtinggggg
potiuk commentedon Dec 20, 2022
Well, maybe one of you would like to take on the task ? I t waits for someone who knows ui to pick it up. As everything in open sources will be implemented when someone implements it :).
Or maybe find someone who could do it of you want it so badly? Anyone can volunteer and implement it actually so if you know someone who knows the ui frameworks and could implement it - convince that someone to volunteer it and it is the fastest way to get it done.
1 remaining item
djpirra commentedon Aug 8, 2023
It would even be better if we could define themes to be applied on the UI. Would be really awesome.
potiuk commentedon Aug 8, 2023
Yes. This feature still waits for somene to implement it.
bengabp commentedon Sep 4, 2023
No one has implemented it yet ???
potiuk commentedon Sep 4, 2023
Maybe you would like to volunteer and implement it @bengabp ?
I think this task is waiting for someone who is interested in it an will implement it. you can also find someone who would like to implement it and contribute it. This is how it works for open-source development when you have mostly volunteers contributing. Anyone could contribute it - and finding time or someone who could contribute it is the fastest way to get something you really want.
Andrew-Wichmann commentedon Jan 4, 2024
I'm not sure if this goes against the philosophy / licensing of Airflow, but I would love to extend this dark mode theme idea into a broader feature set that would enable white labeling. I picked up the idea at a GrafanaLive conference where a presenter showed a dashboard where the color scheme matched the company's color scheme. I think that would be awesome in Airflow.
potiuk commentedon Jan 4, 2024
Yes. It could be done. No licencing or philosophy problem. It just waits for somoene who will implement it. there are always a lot of ideas, but far less number people who will to spend their time and energy (and skils) to contribute implementations of those :)
Andrew-Wichmann commentedon Jan 7, 2024
I hear ya'. I'm not demanding anything. I really like the software. Thank you for your time and effort
AndrewNLauder commentedon Apr 12, 2024
Looks like nobody has taken a stab at this one. Are you still interested in it?
sozelfist commentedon Jun 27, 2024
I have checked out Apache Airflow for the dark mode feature and see that @YounHS implemented the feature. The PR was merged 7hr ago, I love the new feature and will give it a try right now. Thank @YounHS for bringing the great feature to Apache Airflow.
jscheffl commentedon Jul 28, 2024
Closing as fixed in #39355 (even though the current implementation is marked experimental)