You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Update the architecture overview to include Triggerer #21071
I wonder if it would be better to generate the diagram with code, for example: https://github.com/mingrammer/diagrams
that way we can update the diagram by modifying code and pre commit can generate the image when the code is changed. This will make future modification very simple.
Absolutely. I would even said we can continue using Mermaid: https://github.com/mermaid-js/mermaid it's popular, open-source, we already use it in CI documentation and it even supported by Github by default - so if we add the diagram as file in Github it will be rendered there when someone opens it and you will be able to compare rendered images when there is a change in PR.
Activity
eladkal commentedon Feb 26, 2023
I wonder if it would be better to generate the diagram with code, for example: https://github.com/mingrammer/diagrams
that way we can update the diagram by modifying code and pre commit can generate the image when the code is changed. This will make future modification very simple.
potiuk commentedon Feb 26, 2023
Absolutely. I would even said we can continue using Mermaid: https://github.com/mermaid-js/mermaid it's popular, open-source, we already use it in CI documentation and it even supported by Github by default - so if we add the diagram as file in Github it will be rendered there when someone opens it and you will be able to compare rendered images when there is a change in PR.
potiuk commentedon Feb 26, 2023
See https://github.com/apache/airflow/blob/main/CI_DIAGRAMS.md - those diagrams are rendeded on-the flight by GitHub
eladkal commentedon Jan 20, 2024
Solved in #36035