Skip to content

Some links in contributor's quickstart table of contents are broken #23174

Closed

Description

@RNHTTR

What do you see as an issue?

In CONTRIBUTORS_QUICK_START.rst, the links in the table of contents that direct users to parts of the guide that are hidden by the drop down don't work if the drop down isn't expanded. For example, clicking "Setup Airflow with Breeze" does nothing until you open the appropriate drop down Setup and develop using <PyCharm, Visual Studio Code, Gitpod>

Solving the problem

Instead of having the entire documentation blocks under Setup and develop using {method} dropdowns, there could be drop downs under each section so that the guide remains concise without sacrificing the functionality of the table of contents.

Anything else

I'm happy to submit a PR eventually, but I might not be able to get around to it for a bit if anyone else wants to handle it real quick.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Activity

  1. RNHTTR commented on Apr 22, 2022

    @RNHTTR
    ContributorAuthor

    Also, isn't breeze agnostic to a contributor's code editor? Maybe breeze should have its own header section without being embedded in the drop down so it doesn't get repeated a few times.

  2. potiuk commented on Apr 22, 2022

    @potiuk
    Member

    Some good ideas. We might want to redo some of the Breeze docs once we finish #12282 . Breeze will get simpler to use and more powerful after the rewrite so some of the content here might be reshuffled at least or rewrritten

  3. potiuk commented on May 17, 2022

    @potiuk
    Member

    I split it into separate pages to make it nicer. I think the duplication is useful - as mostly people focus on the IDE they know best. If you have power-users who do not need IDEs. they don't need QUICK conributor's guides.

  4. ashb commented on May 17, 2022

    @ashb
    Member

    @RNHTTR Do Jarek's changes (now on main) fix this do you think? Can we close this now?

  5. potiuk commented on May 17, 2022

    @potiuk
    Member

    Not yet on main :) need an approval for #23762 and they will close this one when merged :)

  6. ashb commented on May 18, 2022

    @ashb
    Member

    Not yet on main :) need an approval for #23762 and they will close this one when merged :)

    🤦🏻

  7. potiuk commented on May 18, 2022

    @potiuk
    Member

    Yeah @RNHTTR , any improvments proposals/input there are most welcome :).

  8. RNHTTR commented on May 18, 2022

    @RNHTTR
    ContributorAuthor

    Yeah @RNHTTR , any improvments proposals/input there are most welcome :).

    Sure, I'll have a look today. Would it make sense to migrate all the docs from .rst to markdown?

  9. potiuk commented on May 18, 2022

    @potiuk
    Member

    In this case - absolutely. But I guess we can do it as next step.

  10. added a commit that references this issue on May 24, 2022
    1bf6dde
  11. added a commit that references this issue on Jun 2, 2022
    b10afd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions