Repository navigation
Helm Chart: Allow adding annotations to statsd deployment #25446
Description
Description
Helm Chart does not allow adding annotations to StatsD deployment. We should add it.
Use case/motivation
In our Kubernetes cluster we need to set annotations on deployments that should be scraped by Prometheus. Having an exporter that does not get scraped defeats the purpose 🙂
Related issues
No response
Are you willing to submit a PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
Reacted by Matt Lohier
Activity
boring-cyborg commentedon Aug 1, 2022
Thanks for opening your first issue here! Be sure to follow the issue template!
jedcunningham commentedon Aug 2, 2022
@sbrandtb, would you be interested in opening a PR to add it?
Edit: Oh, just noticed you ticked the box! Have at it 🎉. If you get stuck feel free to post in #helm-chart-official or #airflow-how-to-pr on slack.
sbrandtb commentedon Aug 3, 2022
@jedcunningham Yes, that should be no problem. I just need to find some time for doing it. Probably not this week, but next.
potiuk commentedon Aug 17, 2022
I assigned you now @sbrandtb but I am happy to co-assign you as well @joshuaghezzi (but you need to comment here)
joshuaghezzi commentedon Aug 17, 2022
@potiuk sounds good. apologies @sbrandtb around the confusion that I was working on this. Will be sure to give you a heads up in the future.
sbrandtb commentedon Aug 31, 2022
As I said: No offense. Just not a good job sticking to the process 🙂 I unassigned myself again because I am not part of the solution anymore. Waiting for this to be released, thanks