Repository navigation
annotations in logs pvc #28745
Description
Official Helm Chart version
1.7.0 (latest released)
Apache Airflow version
2.5.0
Kubernetes Version
v1.22.8+d48376b
Helm Chart configuration
No response
Docker Image customisations
No response
What happened
When creating the dags pvc, it is possible to inject annotations to the object.
What you think should happen instead
There should be the possibility to inject annotations to the logs pvc as well.
How to reproduce
No response
Anything else
We are using annotations on pvc to disable the creation of backup snapshots provided by our company platform. (OpenShift)
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
Activity
boring-cyborg commentedon Jan 5, 2023
Thanks for opening your first issue here! Be sure to follow the issue template!
potiuk commentedon Jan 17, 2023
Feel free to add PR adding it @do-it-tim
amoghrajesh commentedon Jan 31, 2023
@potiuk @do-it-tim if nobody is actively developing this, i would be more than happy to take it up. I would require some more context and concrete idea before starting though.
do-it-tim commentedon Jan 31, 2023
Glad to here that.
There are differences between the creation of dags pvc versus logs pvc.
You can compare these two files:
https://github.com/apache/airflow/blob/main/chart/templates/dags-persistent-volume-claim.yaml#L32-L35
vs
https://github.com/apache/airflow/blob/main/chart/templates/logs-persistent-volume-claim.yaml
There is no possibility to add annotations in the logs pvc.
Hope this helps!
Thanks
amoghrajesh commentedon Jan 31, 2023
Oh, thanks @do-it-tim. It would be nice to accept it from:
.Values.logs.persistence.annotations?do-it-tim commentedon Jan 31, 2023
yes, think that would be the equivalent way to do it.
amoghrajesh commentedon Jan 31, 2023
I can take it up then. @potiuk / @do-it-tim can I?
amoghrajesh commentedon Jan 31, 2023
@do-it-tim added support for this in #29270.
amoghrajesh commentedon Feb 21, 2023
@potiuk we can close this. It has been merged