Repository navigation
Fix adding annotations for dag persistence PVC #29621
Description
Official Helm Chart version
1.8.0 (latest released)
Apache Airflow version
2.5.0
Kubernetes Version
v1.25.4
Helm Chart configuration
The dags persistence section doesn't have a default value for annotations and the usage looks like:
annotations:
{{- if .Values.dags.persistence.annotations}}
{{- toYaml .Values.dags.persistence.annotations | nindent 4 }}
{{- end }}
Docker Image customizations
No response
What happened
As per the review comments here: #29270 (review), due to this design, the upgrades might suffer. Fix them to be helm upgrade friendly
What you think should happen instead
The design should be written in an helm upgrade friendly way, refer to this suggestion #29270 (review)
How to reproduce
Anything else
No response
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
Activity
boring-cyborg commentedon Feb 20, 2023
Thanks for opening your first issue here! Be sure to follow the issue template!
potiuk commentedon Feb 20, 2023
Feel free to fix them @amoghrajesh . Assigned you
hussein-awala commentedon Feb 20, 2023
@potiuk we can close it since #29622 is megred.
amoghrajesh commentedon Feb 21, 2023
@potiuk we can close this issue. The PR is merged
potiuk commentedon Feb 21, 2023
For the future @amoghrajesh -> please remember to add description and ("Fixes: #PR") outside of the comment section so that the issues get closed automatically when PR is merged :)