Skip to content

Marking task state as Failed or Success without taskinstance edit role is resulting into partial empty screen #37451

Description

@sreenusuuda

Apache Airflow version

2.8.1

If "Other Airflow 2 version" selected, which one?

No response

What happened?

Marking task state as Failed or Success without task instance edit role is resulting into partial empty screen as shown below instead of Access Denied message.

What you think should happen instead?

We should show proper messaging saying user is lacking permission.

How to reproduce

  1. Create new user and assign user with can edit dags, can read dag runs, can edit dag runs permissions.
  2. Try to login with user and click on the specific Dag.
  3. Select task and try to mark it as Failed or Success.

Operating System

mac os

Versions of Apache Airflow Providers

No response

Deployment

Docker-Compose

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Activity

  1. boring-cyborg commented on Feb 15, 2024

    @boring-cyborg

    Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

  2. added
    priority:lowBug with a simple workaround that would not block a release
    area:UIRelated to UI/UX. For Frontend Developers.
    and removed
    needs-triagelabel for new issues that we didn't triage yet
    on Feb 20, 2024
  3. jscheffl commented on Feb 20, 2024

    @jscheffl
    Contributor

    I did a regression and can confirm this small UI glitch.
    If user permissions are missing to edit task instances (needed to set state to success/failure) then the action buttons should rather be hidden to prevent the follow-up missing error handling in UI.

  4. RodrigoGanancia commented on Mar 7, 2024

    @RodrigoGanancia
    Contributor

    Hey, can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area:UIRelated to UI/UX. For Frontend Developers.good first issuekind:bugThis is a clearly a bugpriority:lowBug with a simple workaround that would not block a release

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions