Repository navigation
Include .Values.volumeMounts into chart/templates/cleanup/cleanup-cronjob.yaml #40191
Description
Description
Since all templates supported airflow_config_mount supports Values.volumeMounts (except cleanup-cronjob.yaml)
Is it possible to add Values.volumeMounts support to cleanup-cronjob.yaml as well?
Thank you
Use case/motivation
use custom ConfigMap for airflow_local_settings.py instead of .Values.airflowLocalSettings
Related issues
No response
Are you willing to submit a PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
Activity
boring-cyborg commentedon Jun 12, 2024
Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.
potiuk commentedon Jun 12, 2024
Sure. Feel free to add it.
sanskrutikhedkar9 commentedon Jun 12, 2024
I am interested. Could you please assign this to me
potiuk commentedon Jun 12, 2024
Done
amoghrajesh commentedon Jul 5, 2024
@sanskrutikhedkar9 are you working on this actively?
dada-engineer commentedon Sep 17, 2024
I would like to jump in here and fix this issue alongside with a problem that you are not able to deactivate the job history because the check {{ if .Values.cleanup.successfulJobsHistoryLimit }} is false if I use --set cleanup.successfulJobsHistoryLimit=0 and then the default of k8s (3) is used.
Are you fine with this or do you prefer a separate issue here?
fix(helm): render global volumes and volume mounts into cleanup job (#…
fix(helm): render global volumes and volume mounts into cleanup job (a…
fix(helm): render global volumes and volume mounts into cleanup job (a…