SSH/SFTP over socks proxy - host_proxy_cmd as extra param

[mstangler]

Description

Now i evaluate and PoC AirFlow.

Please consider make "host_proxy_cmd" as one of extra parameter and use current behavior as fallback, if not set.

I'm new in python/AirFlow world, so there is possibility i miss something :) - be gentle

Use case/motivation

It is mandatory for me to use SFTP over socks proxy. In current tool, (which does not support proxy either) i use bash workaround -o ProxyCommand='ncat --proxy-auth proxy_user:**** --proxy proxy_host:port %h %p'.

sftp -i 'private.key' -o BatchMode=yes -P 22 -o ProxyCommand='ncat --proxy-auth proxy_user:**** --proxy proxy_host:port %h %p' 'sftp_user@sftp_host:'

As far as i dive into documentation and provider source (SFTPHook, SSHHook), there is no externalized parameter for proxy command config, but it sets internally proxy command from ssh config file "~/.ssh/config" (as "proxycommand") and then forward into encapsulated Paramiko object using paramiko.ProxyCommand(). This approach is not convenient for me, i rather have all the configuration on the same location for simple CI, avoid underlying OS artifacts as much as possible

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

[potiuk]

I marked it as good first issue. Hopefully someone will pick it up and implement, but the fastest way to get is to contribute it - other than that, it will have to wait for a volunteer to implement it.

[geraj1010]

This is an interesting issue. I had a use case, where I had to utilize a jump server to connect to SFTP behind a firewall and ended up extending the SFTPHook to do that. I was thinking of providing an update to the hook to do this out-of-box if it makes sense to.

[ajitg25]

Hello @potiuk

As per the requirement, I have added a host_proxy_cmd parameter to SSHHook and SFTPHook.
The description was detailed, so I went ahead and worked on it before requesting an assignment—my apologies for that. I have raised a draft PR here.

Could you please review it and let me know if my understanding is correct? Also, kindly assign this issue to me.

Thank you for your time and understanding!

[potiuk]

Looks good @ajitg25 -> And there is no need to ask for assignment. The only thing you are risking is that someone is working on it in parallel, but this is not a problem either, worst thing you can compare your changes with someone else's and maybe learn something.

Approved. merging when it completes. Also it's better to just make the PR as "ready for review" - we genereally do not review PRs that are "draft" and making it "ready for review" make it, well, ready for review. I clicked the "Ready for review" for you.

[ajitg25]

Thank you @potiuk !!