Skip to content

Incorrect FutureWarning possibly caused by a missing PR in 2.10.3 #43794

Closed

Description

@zachliu

Apache Airflow version

2.10.3

If "Other Airflow 2 version" selected, which one?

No response

What happened?

In Airflow 2.10.3 configuration.py file, we have

for section, key in self.sensitive_config_values:
try:
value = self.get(section, key, suppress_warnings=True)

The self.sensitive_config_values returns both ('database', 'sql_alchemy_conn') and ('core', 'sql_alchemy_conn') because in 2.10.3 the deprecated_options variable is not empty. I think it's supposed to be removed. See #42126.

Hence the self.get() raises a warning:

airflow/configuration.py:859 FutureWarning: section/key [core/sql_alchemy_conn] has been deprecated, you should use[database/sql_alchemy_conn] instead. Please update your `conf.get*` call to use the new name

Which confuses our users.

What you think should happen instead?

The warning should not be raised.

How to reproduce

  1. pip Install Airflow 2.10.3
  2. Run cli $ airflow version

Operating System

Debian GNU/Linux 10 (buster)

Versions of Apache Airflow Providers

No response

Deployment

Other Docker-based deployment

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Activity

  1. amoghrajesh commented on Nov 7, 2024

    @amoghrajesh
    Contributor

    @dirrao was this targetted for 2.10.3?

  2. dirrao commented on Nov 9, 2024

    @dirrao
    Contributor

    @dirrao was this targetted for 2.10.3?

    @amoghrajesh This was intended for Airflow 3 not 2.10.
    #42126

  3. potiuk commented on Nov 11, 2024

    @potiuk
    Member

    Yeah - we noticed it as well during the Man's Hackathon :) . It's something we should definitely target in 2.10.4

  4. added this to the Airflow 2.10.4 milestone on Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions