Skip to content

Remove deprecated code from providers before Airflow 2.11.0 release #44559

Description

@eladkal

Body

Following [LAZY CONSENSUS] Remove deprecations from providers prior to Airflow 2.11 release this issue will track the progress of the removal status.

How to remove?

  1. PRs should be easy to review, You can handle more than 1 provider in the same PR but please use judgment about how many files the PR changes. Please use meaningful commit message.
  2. Find all deprecated code in a provider and accommodate for the needed change (normally the code has deprecation warning that indicates what needs to be removed). Make sure you are not removing code that was just deprecated in recent PR and was never released in stable version. Do not bulk remove!
  3. Add entry to CHANGELOG.rst with information about what was removed and how to mitigate (normally it's copy/paste with minor adjustments to the deprecation warning). Use the following blockright after the Changelog line:
main
....

.. warning::
  All deprecated classes, parameters and features have been removed from the {provider_name} provider package.
  The following breaking changes were introduced:

  * what was removed and how to mitigate

  1. If provider was already handled and introduce new deprecation do not remove again (at least not for now).

List of providers:

Maintainers please update the list with the relevant PRs/status

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.

Activity

  1. Prab-27 commented on Dec 2, 2024

    @Prab-27
    Contributor

    Hello @potiuk I'm a newbie
    I would like to confirm whether I should use the v2-10-test branch for this issue since it is related to version 2

  2. kunaljubce commented on Dec 2, 2024

    @kunaljubce
    Contributor

    @Prab-27 If you're talking about which branch to raise the PR on, that should be main. Refer to the tagged PRs for inspiration.

  3. kunaljubce commented on Dec 2, 2024

    @kunaljubce
    Contributor

    @eladkal So in the context of this change, are we good to deprecate the Apache Drill provider completely?

    class DrillOperator(SQLExecuteQueryOperator):

  4. ajitg25 commented on Dec 2, 2024

    @ajitg25
    Contributor

    Hello @eladkal @jedcunningham ,
    I have raised a PR to remove deprecated code from Airbyte providers.
    Please have a look and let me know if anychanges are required.

    Thank you for your time!!

  5. Prab-27 commented on Dec 2, 2024

    @Prab-27
    Contributor

    @eladkal I’m working on the hashicorp provider and will soon raise a PR.

  6. jscheffl commented on Dec 2, 2024

    @jscheffl
    Contributor

    @eladkal I just checked for the noted deprecations in Celery - these are purely for executor interface, not DAG author specific - and the change was just added and require Airflow 2.10.4 as minimum. If we add a breaking change, Celery can not be upgraded for Airflow 2.10.3 and below.
    Therefore I'd recommend to keep the Celery deprecations for a moment. No harm for the intend to help users to migrate.

    --> FYI marked as to keep it. Hope it is OK?

  7. Prab-27 commented on Dec 3, 2024

    @Prab-27
    Contributor

    @jscheffl - How can I determine the version number like 5.0.0 in CHANGELOG.rst?

    I believe the version number in CHANGELOG.rst is derived from the next versions mentioned in provider.yaml .

  8. eladkal commented on Dec 3, 2024

    @eladkal
    ContributorAuthor

    @jscheffl - How can I determine the version number like 5.0.0 in CHANGELOG.rst?

    I believe the version number in CHANGELOG.rst is derived from the next versions mentioned in provider.yaml .

    You don't, see the instructions in step 3. You set main not version. The version number is chosen by release manager during release time.

  9. jason810496 commented on Dec 4, 2024

    @jason810496
    Member

    Working on

    • Elasticsearch
    • Jekins
    • Apache Livy
    • Mongo
    • Redis
    • SendGrid
    • DBT
    • Atlassian Jira
    • Common SQL
  10. kunaljubce commented on Dec 7, 2024

    @kunaljubce
    Contributor

    @eladkal @jscheffl Below have no deprecations. Please update the description -

    • apache.hive
    • apache.flink
    • apache.iceberg
    • apache.impala
    • apache.kafka
    • apache.kylin
  11. potiuk commented on Dec 7, 2024

    @potiuk
    Member

    Updatiing

  12. jscheffl commented on Dec 7, 2024

    @jscheffl
    Contributor

    Updatiing

    Updating descriptions in Github is a pain. I did it already ~10 times and it seems if others update as well then sometimes (at least 10 times already) my changes are lost. Also notes down a few multiple times which have no deprecations. Tracking a set of PRs on a bug ticket is something Github is not made for :-(

  13. kunaljubce commented on Dec 7, 2024

    @kunaljubce
    Contributor

    FYI - Working on Apache Drill and Apache Druid deprecations.

  14. potiuk commented on Dec 7, 2024

    @potiuk
    Member

    Updating descriptions in Github is a pain. I did it already ~10 times and it seems if others update as well then sometimes (at least 10 times already) my changes are lost. Also notes down a few multiple times which have no deprecations. Tracking a set of PRs on a bug ticket is something Github is not made for :-(

    What I did it in the past is re-generating those issues automatically from time to time ... Another thing-> I did not link/update the PRs in the list just "clicked" the checkmark - it was good enough usually.

  15. potiuk commented on Dec 7, 2024

    @potiuk
    Member

    But maybe a good idea is to do (or find?) a small tool that should do such update via API?

    say:

    breeze check-issue #12345 --item abc --with-pr #27456
    

    😱

    That would make it far more usable

  16. kunaljubce commented on Dec 7, 2024

    @kunaljubce
    Contributor

    @potiuk @jscheffl While we're at it, below also don't have any deprecations -

    • apache.pig
    • apache.pinot
    • apache.cassandra

    With the apache.druid PR up, looks like we're done with the Apache series of deprecations :)

  17. potiuk commented on Dec 7, 2024

    @potiuk
    Member
    Screenshot 2024-12-07 at 21 51 20

    🚀

  18. potiuk commented on Dec 16, 2024

    @potiuk
    Member

    Is it done ?????! ??? 🚀

  19. potiuk commented on Dec 16, 2024

    @potiuk
    Member

    Shall you do the honors @eladkal and close it ?

  20. eladkal commented on Dec 16, 2024

    @eladkal
    ContributorAuthor

    Created a small followup #44807 to make docs better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions