PowerBIDatasetRefreshOperator task succeeds whereas dataset refresh fails

[Ohashiro]

Apache Airflow version

Other Airflow 2 version (please specify below)

If "Other Airflow 2 version" selected, which one?

2.10.2

What happened?

We use the operator PowerBIDatasetRefreshOperator to refresh our PowerBI datasets. For one of the datasets, the refresh fails (and the refresh status received by the task is "Failed") but the task is marked as SUCCESS.

What you think should happen instead?

The Microsoft API documentation here lists the following status: Unknown, Completed, Failed, Disabled. I think that the task should fail if the refresh status is not "Completed".

In the code here, the operator checks only if there is an error in the request to get the status.

How to reproduce

This bug appears when a Dataset can't be refreshed due to an error in the Dataset. Example: duplicate value in a column supposed to be "Unique"

Operating System

linux

Versions of Apache Airflow Providers

apache-airflow-providers-microsoft-azure==11.1.0

Deployment

Google Cloud Composer

Deployment details

No response

Anything else?

This bug occurs every time we run the operator.

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

[eladkal]

Feel free to raise PR.
I recommend having the statuses defined in the hook. Similar to:

airflow/providers/src/airflow/providers/amazon/aws/hooks/athena.py

Lines 69 to 82 in 1275fec

	INTERMEDIATE_STATES = (
	"QUEUED",
	"RUNNING",
	)
	FAILURE_STATES = (
	"FAILED",
	"CANCELLED",
	)
	SUCCESS_STATES = ("SUCCEEDED",)
	TERMINAL_STATES = (
	"SUCCEEDED",
	"FAILED",
	"CANCELLED",
	)