Skip to content

Get rid of *.zip in tests cases #46449

Description

@Lee-W

Description

We should generate the zip file in our test case (i.e., include the files we want to zip but not the zip file itself) and then do the test instead of uploading it to the repo. Currently, we have the following 2 zip files.

  • tests/dags/test_dag_warnings.zip
  • tests/dags/test_zip.zip

In addition to it, we should have a pre-commit to avoid someone from commit a zip file.

Use case/motivation

zip files are hard to review and could incur security issues.

Related issues

#46231 (comment)

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions