Repository navigation
Clean redundant Webserver configs #49896
Description
We replaced Websever with API server serving static JS in Airflow 3.0 and hence removed lot of Webserver configuration. However, the following configuration still exists, and I think most, if not al,l can be nuked
- 'access_denied_message', Move access_denied_message webserver config to fab #50208
- 'secret_key', Move secret_key config to api section #50839
- 'expose_config', Move webserver expose_config to api section #50209
- 'expose_hostname', Move webserver expose_hostname config to fab #50269
- 'grid_view_sorting_order', Move grid_view_sorting_order config to api #50656
- 'log_fetch_timeout_sec', Move webserver config options to api #50693
- 'hide_paused_dags_by_default', Move webserver config options to api #50693
- 'page_size', Move webserver config options to api #50693
- 'navbar_color', Move webserver config to fab provider #50774
- 'navbar_text_color', Move webserver config to fab provider #50774
- 'navbar_hover_color', Move webserver config to fab provider #50774
- 'navbar_text_hover_color', Move webserver config to fab provider #50774
- 'default_wrap', Move webserver config options to api #50693
- 'x_frame_enabled', Move webserver config to fab provider #50774
- 'instance_name_has_markup', Move webserver config options to api #50693
- 'auto_refresh_interval', Move webserver config options to api #50693
- 'warn_deployment_exposure', Move webserver config options to api #50693
- 'enable_swagger_ui', Move enable_swagger_ui config to api #50896
- 'require_confirmation_dag_change' Move webserver config options to api #50693
Activity
pierrejeambrun commentedon May 5, 2025
Some of them are still used and more complicated to remove/migrate, I'll do them in separate PRs. (part are fab provider, part is core etc.)
pierrejeambrun commentedon May 19, 2025
@kaxil I just realized that now that we moved some pieces from
webservertoapi. (targetted for 3.1.0), people upgrading from3.0.0to3.1.0will need toconfig lintagain because otherwise their config will not have thatapisection that core is now looking for, and will most likely crash.Is that acceptable, what do you think is the best way. (I know this isn't great, but I couldn't find a better option, or we still look for
webserversection but this will emit deprecation warning, until AF4...)pierrejeambrun commentedon May 19, 2025
cc: @potiuk @jedcunningham
potiuk commentedon May 19, 2025
Yes. We should deprecate those.
pierrejeambrun commentedon May 19, 2025
So core should still be looking for
webserver.my_config(old location) ?What about configs moved to providers, is that the same, provider should still look for
webservereven if it's expected to be infabnow ? Or since we introduced a lower bound on both side (core => provider, provider => core) we can assume that the config section will be up to date ?kaxil commentedon May 19, 2025
Yeah for ones where we do still use those config, we should deprecate them first unfortunately
pierrejeambrun commentedon May 19, 2025
My bad, sorry for the confusion, double checked with Jed, yes those will raise deprecation warnings for core moved in core.
potiuk commentedon May 19, 2025
Yeah. Core to Core is straightforward - > core to fab requires bumping min version(s), really - that's the simplest way, another option is to add a code in fab provider to manually fallback to the old webserver settings with deprecations.