Skip to content

Fork CI reconciler: count a workflow added by a PR as project CI only if its jobs did work #74905

Closed

Description

@potiuk

The fork CI reconciler (AIP-120, #74822) decides that a project CI run "bypassed the gate" when the base branch's copy of the run's workflow is not triggered by the run's event. A workflow the pull request adds therefore always counts, even if all of its jobs were skipped in apache/airflow (for example a fork-only workflow guarded by if: github.repository != 'apache/airflow'). If the pull request also changes .github/workflows/, which adding the file does, it is closed for gate tampering although no project CI work ran.

Proposed: for workflows the base branch does not trigger, list the run's jobs as is already done for long ci-amd.yml runs, and count the run only if a job ran. Keep failing closed when the job list cannot be read.

Code: BypassFinder._did_run_project_ci in dev/breeze/src/airflow_breeze/utils/fork_ci_reconcile.py.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions