Repository navigation
Fork CI reconciler: retry a lost "push again" nudge #74908
Description
When a gated pull request goes from setup_required to awaiting_push, the reconciler (AIP-120, #74822) edits the state comment and then posts a new comment asking the contributor to push again. If setting the status or posting that comment fails after the state comment was edited, the next run sees awaiting_push and never posts the nudge. The contributor gets no prompt before the inactivity closure.
Proposed: post the nudge before recording awaiting_push in the state comment, or record in the marker that the nudge is pending and clear it only after it was posted. Add a test where posting the nudge fails once.
Code: classify and apply_plan in dev/breeze/src/airflow_breeze/utils/fork_ci_reconcile.py.
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
Activity
potiuk commentedon Oct 27, 2026
The same gap now applies to a second comment. #75814 adds a "Fork CI stopped running" comment, posted when a pull request whose fork CI had worked (for example
awaiting_push,failedorgreen) moves tosetup_requiredbecause the fork'sTests (AMD)workflow was disabled or removed. Like the nudge, it is posted after the state comment recordssetup_required. If posting it fails, the next run seessetup_requiredand does not post it again. The author then gets no notice before the inactivity closure.Whichever fix lands here (posting before recording the new state, or a pending-notification flag in the marker) should cover both comments. Both sites in
classifyindev/breeze/src/airflow_breeze/utils/fork_ci_reconcile.pylink to this issue.Drafted-by: Claude Code (Claude Opus 5); reviewed by @potiuk before posting