Repository navigation
Missing unit tests for some modules in providers package #8278
Description
Description
We have a rule that every file in the providers directory should have tests. This is true in many cases, but there are minor exceptions.
https://github.com/apache/airflow/blob/master/tests/test_project_structure.py#L29-L50
-
tests/providers/amazon/aws/hooks/test_athena.py -
tests/providers/apache/cassandra/sensors/test_record.py -
tests/providers/apache/cassandra/sensors/test_table.py -
tests/providers/apache/hdfs/sensors/test_web_hdfs.py -
tests/providers/apache/hive/operators/test_vertica_to_hive.py -
tests/providers/apache/pig/operators/test_pig.py -
tests/providers/apache/spark/hooks/test_spark_jdbc_script.py -
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py -
tests/providers/google/cloud/operators/test_datastore.py -
tests/providers/google/cloud/operators/test_sql_to_gcs.py -
tests/providers/google/cloud/sensors/test_bigquery.py -
tests/providers/google/cloud/utils/test_field_sanitizer.py -
tests/providers/google/cloud/utils/test_field_validator.py -
tests/providers/google/cloud/utils/test_mlengine_operator_utils.py -
tests/providers/google/cloud/utils/test_mlengine_prediction_summary.py -
tests/providers/jenkins/hooks/test_jenkins.py -
tests/providers/microsoft/azure/sensors/test_azure_cosmos.py -
tests/providers/microsoft/mssql/hooks/test_mssql.py -
tests/providers/oracle/operators/test_oracle.py -
tests/providers/qubole/hooks/test_qubole.py -
tests/providers/samba/hooks/test_samba.py -
tests/providers/sqlite/operators/test_sqlite.py -
tests/providers/yandex/hooks/test_yandex.py
I would be happy if someone would complete the missing tests.
If you decide to finish this ticket you don't have to do all the work yourself. One PR can only deal with a single file and it's ok.
Are you wondering how to start contributing to this project? Start by reading our contributor guide
Use case / motivation
Raising test coverage facilitates refactoring and prevents regression.
For the contributor, this is an opportunity to learn more about the structure of the project and to learn better good practices in writing tests in Python.
Related Issues
N/A
Activity
[-]Missing tests for some modules in providers package[/-][+]Missing unit tests for some modules in providers package[/+]samuelkhtu commentedon Jun 11, 2020
If no one is working on the test_mssql.py, I can take work it.
tests/providers/microsoft/mssql/hooks/test_mssql.py
[AIRFLOW-8278] Added tests for yandex hooks apache#8278
subkanthi commentedon Jul 5, 2020
Added tests for Yandex hook
https://github.com/apache/airflow/pull/9665/files
[AIRFLOW-8278] Fixed lint errors for yandex hooks tests apache#8278
[AIRFLOW-8278] Fixed lint errors for yandex hooks tests apache#8278
[AIRFLOW-8278] Fixed flake8 errors apache#8278
subkanthi commentedon Jul 12, 2020
Added unit test for jenkins hook
#9767
rootcss commentedon Jul 18, 2020
I've picked Cassandra table and record sensors hook. (primarily because, I ❤️ Cassandra)
rootcss commentedon Jul 18, 2020
Picked
tests/providers/apache/hdfs/sensors/test_web_hdfs.pymik-laj commentedon Jul 18, 2020
@rootcss Wouldn't you be willing to give some love for this ticket?
#8189
rootcss commentedon Jul 18, 2020
@mik-laj Here's some more ❤️ for Cassandra - #9877
ari-hacks commentedon Jul 19, 2020
I'd like to tackle
tests/providers/microsoft/azure/sensors/test_azure_cosmos.pyrootcss commentedon Jul 22, 2020
I'm picking the following tests:
cc: @mik-laj
rootcss commentedon Jul 23, 2020
@mik-laj
MsSqlHookin airflow/providers/microsoft/mssql/hooks/mssql.py is deprecated. Do we still need to add tests for it?mik-laj commentedon Jul 25, 2020
@rootcss If someone is willing, they can add tests, but it is not necessary. I will be happy without tests for this module.
mik-laj commentedon Jul 25, 2020
@rootcss As far as I know, Tomek is working on tests for Datastore.
@turbaszek Can you confirm that?
mik-laj commentedon Jul 25, 2020
I found PR: PolideaInternal#946
rootcss commentedon Jul 26, 2020
Sure. I've removed it from my list.
rootcss commentedon Jul 26, 2020
@mik-laj I think, rest of the tests have been picked already. We're close to close this issue :)
rootcss commentedon Jul 27, 2020
I've picked
tests/providers/google/cloud/utils/test_mlengine_prediction_summary.pymik-laj commentedon Sep 8, 2020
The ticket has been completed :-D
Thanks to everyone who participated in this task.
More info: #10799
potiuk commentedon Sep 8, 2020
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
rootcss commentedon Sep 8, 2020
👍