add azure files to gcs transfer operator by FHoffmannCode · Pull Request #10991 · apache/airflow

FHoffmannCode · 2020-09-17T12:41:08Z

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

boring-cyborg · 2020-09-17T12:41:11Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

FHoffmannCode · 2020-09-17T13:02:16Z

@turbaszek

michalslowikowski00 · 2020-09-17T13:02:24Z

@FHoffmannCode are you going to add example dag? :)
Like here.
https://github.com/apache/airflow/tree/master/airflow/providers/microsoft/azure/example_dags

olchas

One minor issue in docstring, but LGTM overall.

michalslowikowski00 · 2020-09-25T13:17:17Z

LGTM.
Great job. :)

github-actions · 2020-10-05T07:41:27Z

The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).

You can checks the status of those images in The workflow run

github-actions · 2020-10-05T08:14:28Z

The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

github-actions · 2020-10-05T08:20:22Z

The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

github-actions · 2020-10-06T13:21:21Z

The Build Workflow run is cancelling this PR. The job has been cancelled by another workflow.

boring-cyborg · 2020-10-07T09:09:00Z

Awesome work, congrats on your first merged pull request!

boring-cyborg Bot added provider:microsoft-azure Azure-related issues provider:google Google (including GCP) related issues labels Sep 17, 2020

FHoffmannCode closed this Sep 17, 2020

FHoffmannCode reopened this Sep 17, 2020

michalslowikowski00 reviewed Sep 17, 2020

View reviewed changes

Comment thread airflow/providers/microsoft/azure/hooks/azure_fileshare.py Outdated

olchas reviewed Sep 17, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

olchas reviewed Sep 17, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

olchas reviewed Sep 17, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

olchas reviewed Sep 17, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

olchas reviewed Sep 17, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

turbaszek reviewed Sep 17, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

turbaszek reviewed Sep 17, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch from 4d3ddfe to f582a73 Compare September 25, 2020 10:42

FHoffmannCode requested a review from turbaszek September 25, 2020 10:45

olchas reviewed Sep 25, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

olchas approved these changes Sep 25, 2020

View reviewed changes

michalslowikowski00 reviewed Sep 25, 2020

View reviewed changes

Comment thread docs/howto/operator/google/transfer/azure_fileshare_to_gcs.rst Outdated

michalslowikowski00 reviewed Sep 25, 2020

View reviewed changes

Comment thread tests/providers/google/cloud/transfers/test_azure_fileshare_to_gcs.py Outdated

michalslowikowski00 reviewed Sep 25, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

michalslowikowski00 reviewed Sep 25, 2020

View reviewed changes

Comment thread airflow/providers/microsoft/azure/example_dags/example_azure_fileshare_to_gcs.py Outdated

michalslowikowski00 reviewed Sep 25, 2020

View reviewed changes

Comment thread airflow/providers/microsoft/azure/example_dags/example_azure_fileshare_to_gcs.py Outdated

michalslowikowski00 reviewed Sep 25, 2020

View reviewed changes

Comment thread tests/providers/google/cloud/transfers/test_azure_fileshare_to_gcs.py Outdated

michalslowikowski00 reviewed Sep 25, 2020

View reviewed changes

Comment thread tests/providers/microsoft/azure/hooks/test_azure_fileshare.py Outdated

FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch 2 times, most recently from 1d9d0e6 to 4ed1b66 Compare September 25, 2020 12:47

turbaszek reviewed Sep 27, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/example_dags/example_azure_fileshare_to_gcs.py Outdated

turbaszek reviewed Sep 30, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

turbaszek reviewed Sep 30, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

turbaszek reviewed Sep 30, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch from 3658506 to 282e2b7 Compare September 30, 2020 13:31

FHoffmannCode requested a review from turbaszek September 30, 2020 13:31

FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch from 282e2b7 to fea7f79 Compare October 1, 2020 08:22

turbaszek reviewed Oct 1, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

turbaszek reviewed Oct 1, 2020

View reviewed changes

Comment thread airflow/providers/microsoft/azure/hooks/azure_fileshare.py Outdated

FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch 2 times, most recently from d868e0e to 1f0b8be Compare October 2, 2020 08:11

FHoffmannCode requested a review from turbaszek October 2, 2020 08:11

FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch from 1f0b8be to cbcb490 Compare October 5, 2020 07:41

FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch 2 times, most recently from e05c22b to 697f32a Compare October 6, 2020 13:14

turbaszek reviewed Oct 6, 2020

View reviewed changes

Comment thread airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py Outdated

add azure files to gcs transfer operator

fab668b

FHoffmannCode force-pushed the add-azure-files-to-gcs-transfer-operator branch from 697f32a to fab668b Compare October 7, 2020 07:14

FHoffmannCode requested a review from turbaszek October 7, 2020 07:29

turbaszek approved these changes Oct 7, 2020

View reviewed changes

turbaszek merged commit b0fcf67 into apache:master Oct 7, 2020

turbaszek deleted the add-azure-files-to-gcs-transfer-operator branch October 7, 2020 09:08

eladkal mentioned this pull request Jan 17, 2022

Return files destination uris in all ToGCS operators #11323

Closed

13 of 14 tasks

Conversation

FHoffmannCode commented Sep 17, 2020

Uh oh!

boring-cyborg Bot commented Sep 17, 2020

Uh oh!

FHoffmannCode commented Sep 17, 2020

Uh oh!

michalslowikowski00 commented Sep 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

olchas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michalslowikowski00 commented Sep 25, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 5, 2020

Uh oh!

github-actions Bot commented Oct 5, 2020

Uh oh!

github-actions Bot commented Oct 5, 2020

Uh oh!

github-actions Bot commented Oct 6, 2020

Uh oh!

Uh oh!

boring-cyborg Bot commented Oct 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

michalslowikowski00 commented Sep 17, 2020 •

edited

Loading