Repository navigation
Implement expand_kwargs() against a literal list - #25925
Merged
Merged
Conversation
Member
|
(Attempted to resolve conflicts vis GH, may not have worked out very well) |
uranusjr
force-pushed
the
aip-42-expand-kwargs-literal
branch
2 times, most recently
from
August 28, 2022 17:04
e28341f to
2b7452e
Compare
The literal list may contain dict (operator kwargs) or an XComArg (resolved to operator kwargs at runtime).
uranusjr
force-pushed
the
aip-42-expand-kwargs-literal
branch
from
August 29, 2022 08:11
2b7452e to
e28183d
Compare
Probably caused by rebasing.
uranusjr
marked this pull request as ready for review
August 29, 2022 17:12
ashb
approved these changes
Aug 30, 2022
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds literal support to
expand_kwargs():This matches the
expand()interface.This needs #25924 to go in first and is submitted for CI now.