Repository navigation
Add deferrable mode to dataflow operators - #27776
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:google
bhirsz
reviewed
Nov 18, 2022
MrGeorgeOwl
force-pushed
the
dataflow_defferable_mode
branch
5 times, most recently
from
November 24, 2022 11:35
e12f828 to
7595951
Compare
Member
|
Tests failing. |
MrGeorgeOwl
force-pushed
the
dataflow_defferable_mode
branch
3 times, most recently
from
December 9, 2022 08:42
079ac53 to
067b705
Compare
MrGeorgeOwl
force-pushed
the
dataflow_defferable_mode
branch
5 times, most recently
from
December 19, 2022 08:23
7b31c11 to
901352d
Compare
Contributor
Author
|
@potiuk, tests that are failing at the moment are those that come with changes from main branch. Have the same issues in several PRs so I think that changes in PR are okay but I might be wrong |
Member
|
I think there were intermittent/flaky tests - I re-run them to be sure. |
kaxil
reviewed
Dec 21, 2022
kaxil
reviewed
Dec 21, 2022
kaxil
reviewed
Dec 21, 2022
kaxil
reviewed
Dec 21, 2022
kaxil
reviewed
Dec 21, 2022
kaxil
reviewed
Dec 21, 2022
kaxil
reviewed
Dec 21, 2022
kaxil
reviewed
Dec 21, 2022
|
@MrGeorgeOwl -- this is great and we are eagerly awaiting this functionality to save us some headaches! Do you want some help getting it over the finish line? Looks like the outstanding reviews are pretty straightforward :-) Please advise. |
Contributor
Author
|
@brucearctor, thank you for your offer of help I appreciate that. I finished required changes at the moment so PR should be merged after it will be reviewed and approved |
MrGeorgeOwl
force-pushed
the
dataflow_defferable_mode
branch
15 times, most recently
from
January 30, 2023 08:03
9977d08 to
683f62f
Compare
uranusjr
reviewed
Jan 30, 2023
uranusjr
reviewed
Jan 30, 2023
potiuk
requested changes
Jan 30, 2023
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
Comment why we are adding upper-bound limit
MrGeorgeOwl
force-pushed
the
dataflow_defferable_mode
branch
2 times, most recently
from
January 30, 2023 13:44
7fe1466 to
1430b33
Compare
Contributor
Author
|
@potiuk, I've added comment about upper-bound for google library |
…StartFlexTemplateOperator operators
change warning message
MrGeorgeOwl
force-pushed
the
dataflow_defferable_mode
branch
from
January 30, 2023 13:48
1430b33 to
e9ede1f
Compare
potiuk
approved these changes
Jan 30, 2023
20 of 58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.