Skip to content

Add defer mode to GKECreateClusterOperator and GKEDeleteClusterOperator - #28406

Merged
kaxil merged 2 commits into
apache:mainfrom
lwyszomi:defer_gke_cluster_operators
Feb 14, 2023
Merged

kaxil merged 2 commits into
apache:mainfrom
lwyszomi:defer_gke_cluster_operators

Conversation

@MrGeorgeOwl

Copy link
Copy Markdown
Contributor

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg Bot added provider:cncf-kubernetes Kubernetes (k8s) provider related issues area:providers area:system-tests kind:documentation provider:google Google (including GCP) related issues labels Dec 16, 2022
@MrGeorgeOwl
MrGeorgeOwl force-pushed the defer_gke_cluster_operators branch 2 times, most recently from 5931640 to f3f3965 Compare December 19, 2022 08:21
@potiuk

potiuk commented Jan 11, 2023

Copy link
Copy Markdown
Member

conflicts.

@MrGeorgeOwl
MrGeorgeOwl force-pushed the defer_gke_cluster_operators branch 4 times, most recently from bcb4980 to 7893e77 Compare January 23, 2023 15:42
@MrGeorgeOwl

Copy link
Copy Markdown
Contributor Author

@potiuk, I think PR is good and can be merged

@potiuk

potiuk commented Jan 23, 2023

Copy link
Copy Markdown
Member

Just checking with @kaxil and @bhirsz - weren't you working on this already in Astronomer/Google ?

@MrGeorgeOwl

Copy link
Copy Markdown
Contributor Author

@potiuk Yes, I am also working on KubernetesPodOperator but this PR have different operators

@MrGeorgeOwl
MrGeorgeOwl force-pushed the defer_gke_cluster_operators branch 5 times, most recently from 4d95813 to cef3620 Compare January 30, 2023 08:03
@MrGeorgeOwl
MrGeorgeOwl force-pushed the defer_gke_cluster_operators branch from cef3620 to ad95490 Compare January 31, 2023 07:54
@VladaZakharova

Copy link
Copy Markdown
Contributor

Hi Team! @kaxil @potiuk
Can we please merge these changes?

@kaxil
kaxil merged commit 28126c1 into apache:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers area:system-tests kind:documentation provider:cncf-kubernetes Kubernetes (k8s) provider related issues provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants