Skip to content

log the observed status in redshift sensor #29274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josh-fell merged 1 commit into from
Feb 1, 2023
Merged

log the observed status in redshift sensor #29274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions airflow/providers/amazon/aws/sensors/redshift_cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,14 @@ def __init__(
self.aws_conn_id = aws_conn_id

def poke(self, context: Context):
self.log.info("Poking for status : %s\nfor cluster %s", self.target_status, self.cluster_identifier)
return self.hook.cluster_status(self.cluster_identifier) == self.target_status
current_status = self.hook.cluster_status(self.cluster_identifier)
self.log.info(
"Poked cluster %s for status '%s', found status '%s'",

@josh-fell josh-fell Feb 1, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Poked cluster %s for status '%s', found status '%s'",
"Poked cluster %s for status %r, found status %r",

@vandonr-amz vandonr-amz Feb 1, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to apply the suggestion, but can you explain why this would be better ? Both being strings, the output would be exactly the same, wouldn't it ?

@josh-fell josh-fell Feb 1, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Just merely a suggestion for readability and maybe a little future-proofing with all of those statuses if there is some Enum to be created with a nice repr. Certainly isn't a blocking suggestion to use repr or not.

self.cluster_identifier,
self.target_status,
current_status,
)
return current_status == self.target_status

@deprecated(reason="use `hook` property instead.")
def get_hook(self) -> RedshiftHook:
Expand Down