Skip to content

fix template_fields in the decorator task.docker - #29586

Merged
Taragolis merged 11 commits into
apache:mainfrom
jeffery9876:main
Feb 17, 2023
Merged

Taragolis merged 11 commits into
apache:mainfrom
jeffery9876:main

Conversation

@jeffery9876

Copy link
Copy Markdown
Contributor

closes: #29585

Add back the template fields that exists under DockerOperator to task.docker


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg

boring-cyborg Bot commented Feb 17, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@potiuk

potiuk commented Feb 17, 2023

Copy link
Copy Markdown
Member

Would you be so kind and add a test case covering it ?

@jeffery9876

Copy link
Copy Markdown
Contributor Author

will do, Thank you

Would you be so kind and add a test case covering it ?

@jeffery9876

Copy link
Copy Markdown
Contributor Author

Test is added @potiuk

@potiuk

potiuk commented Feb 17, 2023

Copy link
Copy Markdown
Member

Test is added @potiuk

Fantastic ! Thanks

Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
@Taragolis

Copy link
Copy Markdown
Contributor

And also passing static checks required, for avoid manually fix code styles and other stuff, like use ' instead of " you need to setup pre-commit: https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst

@Taragolis
Taragolis dismissed their stale review February 17, 2023 14:00

not relevant anymore

jeffery9876 and others added 2 commits February 17, 2023 16:22
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
@Taragolis
Taragolis merged commit 7bd87e7 into apache:main Feb 17, 2023
@boring-cyborg

boring-cyborg Bot commented Feb 17, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

@josh-fell

Copy link
Copy Markdown
Contributor

@jeffery9876 Woohoo! Congrats on your first contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

template_fields not working in the decorator task.docker

4 participants